Skip to content

chore(kill-mode): remove kill-mode process#778

Open
yanksyoon wants to merge 8 commits intomainfrom
chore/remove-killmode
Open

chore(kill-mode): remove kill-mode process#778
yanksyoon wants to merge 8 commits intomainfrom
chore/remove-killmode

Conversation

@yanksyoon
Copy link
Copy Markdown
Member

Applicable spec:

Overview

Removes kill-mode=process from systemd: The systemd default (control-group) ensures all processes in the cgroup are cleaned up on stop/restart, avoiding potential stuck or orphaned processes.

Rationale

No longer needed & removes orphaned processes

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

Comment thread docs/changelog.md
Agent-Logs-Url: https://github.com/canonical/github-runner-operator/sessions/fdb190f7-56fe-4911-94f8-16309a5fceb1

Co-authored-by: florentianayuwono <76247368+florentianayuwono@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants