Enable encryptedData to be omitted by setting key to null in template#1871
Enable encryptedData to be omitted by setting key to null in template#1871meln5674 wants to merge 1 commit intobitnami-labs:mainfrom
Conversation
73882a6 to
0d6e2bb
Compare
|
hi @meln5674 there are linter errors. Could you take it a look, please? thanks Álvaro |
Signed-off-by: Andrew Melnick <meln5674.5674@gmail.com>
0d6e2bb to
2e4a8df
Compare
|
@alvneiayu It would appear the import and tooling versions have diverged. 3 of the 4 lint findings are deprecated functions called in files I did not modify, but instead the functions themselves are deprecated in the new I should also mention, According to the git history, the version of that module the last time the zz_deepcopy.go file was changed was 0.30.1, but resetting the go.mod version to that results in other errors. I have fixed the one lint finding that was introduced by one of my changes and also ran (As a piece of totally unsolicited advice, from one operator maintainer to another, putting needed tool versions in the go.mod via |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Unstale. Awaiting response. |
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Unstale. Awaiting response. |
|
I will take it a look because other PRs are not having problems with the linters. Looks like something is bumped and it is causing the problem in this PR. I will take it a look ASAP. Thanks @meln5674 |
Description of the change
Make
SealedSecret.spec.template.datafields nullable. A null value indicates that the key should be omitted from the final secret.Change is backwards compatible.
Benefits
Templated Secrets can be used in cases where the set of keys is significant, i.e. extraneous keys are not acceptable.
Possible drawbacks
None known.
Applicable issues
Additional information