Move endpoint resolution from interceptors to pipeline stage#6820
Merged
S-Saranya1 merged 8 commits intofeature/master/core-interceptors-migrationfrom Apr 16, 2026
Merged
Conversation
87d0960 to
305ba3a
Compare
6000d9f to
7b09efe
Compare
…l/endpoint-resolution-refactoring
Fred1155
reviewed
Mar 30, 2026
dagnir
requested changes
Apr 6, 2026
alextwoods
reviewed
Apr 7, 2026
alextwoods
reviewed
Apr 10, 2026
alextwoods
approved these changes
Apr 13, 2026
Fred1155
approved these changes
Apr 14, 2026
dagnir
approved these changes
Apr 14, 2026
b417a87
into
feature/master/core-interceptors-migration
8 of 30 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The SDK uses ExecutionInterceptor for core endpoint resolution functionality. But this interface was
designed for customer extensibility, not internal SDK. This is Part 2 of the core interceptors migration, following the auth scheme resolution refactoring in #6755.
Modifications
1. Codegen — generate resolveEndpoint() in client classes
2. Codegen — generate per-service EndpointResolverUtils
3. Added EndpointResolutionStage
New pipeline stage in sdk-core that runs after AuthSchemeResolutionStage. Calls the service-specific callback, stores RESOLVED_ENDPOINT, copies endpoint headers, applies resolved URL, and reports ENDPOINT_RESOLVE_DURATION metric. Registered in both sync and async pipelines.
4. Added EndpointResolver interface and ClientExecutionParams
EndpointResolver functional interface in sdk-core, endpointResolver field on ClientExecutionParams, ENDPOINT_RESOLVER execution attribute, and wiring in AwsExecutionContextBuilder.
5. De-duplicated AwsEndpointProviderUtils
Created single shared class in aws-core replacing identical per-service generated copies. Deleted the AwsEndpointProviderUtils.java.resource template.
6. Updated S3 presigner and S3Utilities
Removed old endpoint interceptors from both. Added direct endpoint resolution methods that call S3EndpointResolverUtils.ruleParams() and apply the resolved URL.
7. Deleted dead code
Removed EndpointResolverInterceptorSpec, RequestEndpointInterceptorSpec, AuthSchemeInterceptorSpec, their tests, AwsEndpointProviderUtils.java.resource template, and dead generateAuthSchemeInterceptor() method.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License