GH-3471: Fix ByteBuffer handling in VariantUtil and VariantBuilder#3472
Open
rayokota wants to merge 1 commit intoapache:masterfrom
Open
GH-3471: Fix ByteBuffer handling in VariantUtil and VariantBuilder#3472rayokota wants to merge 1 commit intoapache:masterfrom
ByteBuffer handling in VariantUtil and VariantBuilder#3472rayokota wants to merge 1 commit intoapache:masterfrom
Conversation
|
CC: @alamb to help kick off test workflows. |
steveloughran
approved these changes
Apr 15, 2026
Contributor
steveloughran
left a comment
steveloughran
left a comment
There was a problem hiding this comment.
this is good. does relate to the work in #3481 which needs to pick up the same fix.
getting your patch in first adds the regression tests we need
| int remainingBefore = buf.remaining(); | ||
| VariantBuilder vb = new VariantBuilder(); | ||
| vb.appendBinary(buf); | ||
| Assert.assertEquals(positionBefore, buf.position()); |
Contributor
There was a problem hiding this comment.
nit add a "position" and "remaining" description for better diagnostics on CI runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix
ByteBufferhandling inVariantUtilandVariantBuilder.What changes are included in this PR?
VariantUtil.getMetadataMapreading string bytes from the wrong positionwhen the metadata
ByteBufferhas a non-zeroposition(). Changedslice(metadata, stringStart + offset)toslice(metadata, pos + stringStart + offset) to match the array-backed branch.VariantBuilder.appendBinarymutating the caller'sByteBufferby usingbinary.duplicate(), consistent withappendEncodedValue.Are these changes tested?
TestVariantObject.testMetadataWithNonZeroPositionReadOnly: constructs ametadata
ByteBufferwith a non-zero position and read-only flag, then verifiesImmutableMetadata(which callsgetMetadataMap) correctly parses thedictionary. Fails without the fix.
TestVariantScalarBuilder.testBinaryBuilderDoesNotMutateCallerBuffer:verifies that appendBinary does not change the caller's
ByteBufferpositionor remaining count.
Are there any user-facing changes?
Closes #3471