branch-4.1: [fix](be) Add missing SCOPED_ATTACH_TASK in download and move_dir callbacks#62401
Merged
yiguolei merged 1 commit intoapache:branch-4.1from Apr 13, 2026
Merged
Conversation
…lbacks Issue Number: close #xxx Problem Summary: download_callback() and move_dir_callback() in task_worker_pool.cpp use SnapshotLoader/CloudSnapshotLoader to perform HDFS downloads and file moves, but do not attach the MemTracker to the thread context via SCOPED_ATTACH_TASK. This causes memory orphan check failures when these callbacks allocate memory through HDFS operations, as the allocations are not tracked by any MemTrackerLimiter. The parallel upload_callback() already has SCOPED_ATTACH_TASK correctly. Fix: Add SCOPED_ATTACH_TASK(loader->resource_ctx()) in all four missing locations: - download_callback(StorageEngine&): remote_http_download branch - download_callback(StorageEngine&): broker download branch - download_callback(CloudStorageEngine&): cloud download branch - move_dir_callback(StorageEngine&): local move branch
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes memory tracking in BE agent task callbacks by attaching the SnapshotLoader/CloudSnapshotLoader ResourceContext to the current thread via SCOPED_ATTACH_TASK, preventing “orphan” memory allocations during snapshot download/move operations.
Changes:
- Attach task resource context in
download_callback(StorageEngine&)for both remote HTTP snapshot downloads and broker-based downloads. - Attach task resource context in
download_callback(CloudStorageEngine&)for broker-based cloud downloads. - Attach task resource context in
move_dir_callback(StorageEngine&)before performing the local snapshot move.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Apr 13, 2026
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
changed the title
yiguolei
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
cherry-pick #62403
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)