Remove as_any on the PhysicalExpr trait#21573
Merged
timsaucer merged 7 commits intoapache:mainfrom Apr 15, 2026
Merged
Conversation
Leverage Rust 1.86 trait upcasting to remove the `as_any` boilerplate from `PhysicalExpr`, following the same pattern as apache#21346 which did this for `TableProvider`, `SchemaProvider`, `CatalogProvider`, and `CatalogProviderList`. Since `PhysicalExpr: Any`, Rust can now upcast `&dyn PhysicalExpr` to `&dyn Any` directly. This adds `is` and `downcast_ref` convenience methods on `impl dyn PhysicalExpr` and removes `fn as_any` from the trait and all 24 implementors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
documentation
timsaucer
commented
Apr 12, 2026
Comment on lines
-942
to
-951
| Field::new( | ||
| left_col.as_any().downcast_ref::<Column>().unwrap().name(), | ||
| DataType::Int32, | ||
| true, | ||
| ), | ||
| Field::new( | ||
| right_col.as_any().downcast_ref::<Column>().unwrap().name(), | ||
| DataType::Int32, | ||
| true, | ||
| ), |
Member
Author
There was a problem hiding this comment.
It looks at first glance like we're removing a check on the Column type but if you look higher up you can see that left_col is an Arc<Column> so this doesn't impact the test.
timsaucer
commented
Apr 12, 2026
| let literal_expr = lit(10i64); | ||
| let binary_expr = | ||
| Arc::new(BinaryExpr::new(cast_expr, Operator::Gt, literal_expr)); | ||
| let binary_ref = binary_expr.as_any().downcast_ref::<BinaryExpr>().unwrap(); |
Member
Author
There was a problem hiding this comment.
Similar to above, this test didn't really do anything other than step through the as_any() function since binary_expr is already an Arc<BinaryExpr>
16 tasks
nuno-faria
approved these changes
Apr 15, 2026
Contributor
nuno-faria
left a comment
nuno-faria
left a comment
There was a problem hiding this comment.
Thanks @timsaucer, LGTM.
Comment on lines
200
to
344
Contributor
There was a problem hiding this comment.
Not for this PR but the upgrade guide for these changes is becoming quite large. Wouldn't just a single example suffice?
Reduce the upgrade guide section from 9 nearly identical diffs to one representative example, per reviewer feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # datafusion-examples/examples/custom_data_source/custom_file_casts.rs # datafusion/physical-expr/src/expressions/cast_column.rs
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> `main` is not able to compile due to merge race by #21479 and #21573 This PR fixes the conflict ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
asolimando
added a commit
to asolimando/datafusion
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
as_anyfrom trait definitions #21572Rationale for this change
This PR reduces the amount of boilerplate code that users need to write for Physical Expressions.
What changes are included in this PR?
Now that we have trait upcasting since rust 1.86, we no longer need every implementation of this trait to have the as_any function that returns &self. This PR makes Any an supertrait and makes the appropriate casts when necessary.
Are these changes tested?
Existing unit tests.
Are there any user-facing changes?
Yes, the users simply need to remove the as_any function. The upgrade guide is updated.