Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the JavaScript User-Defined Function (UDF) execution within the Apache Beam Python SDK's YAML module. By migrating from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
8f22b5b to
e0f39b8
Compare
|
Run Python PreCommit 3.14 |
|
Run Python PreCommit 3.10 |
|
Run PythonDocker PreCommit 3.13 |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces the js2py library with quickjs to support JavaScript mapping functions in Beam YAML, particularly for Python 3.12 compatibility. The implementation introduces a _QuickJsCallable class and updates the mapping logic to use quickjs. Review feedback highlights a significant performance improvement opportunity by removing manual JSON serialization in favor of quickjs's native ability to handle Python objects directly.
e0f39b8 to
5ba6838
Compare
5ba6838 to
901943c
Compare
|
Run Python PreCommit 3.10 |
|
Run Yaml_Xlang_Direct PreCommit |
|
Run Python PreCommit 3.10 |
1 similar comment
|
Run Python PreCommit 3.10 |
|
Run Python_Dataframes PreCommit 3.14 |
|
Run Python PreCommit 3.11 |
|
Run Python_Examples PreCommit 3.13 |
|
Run Python_Runners PreCommit 3.14 |
|
Run PythonDocker PreCommit 3.14 |
|
Run PythonDocs PreCommit |
|
Run Python PreCommit 3.10 |
|
Run Python PreCommit 3.11 |
|
Run Python PreCommit 3.12 |
|
Run Python PreCommit 3.11 |
|
Run Python_ML PreCommit 3.10 |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.