fix: prevent items from getting continually loaded in S2 async TreeView#9921
Merged
fix: prevent items from getting continually loaded in S2 async TreeView#9921
Conversation
|
Build successful! 🎉 |
devongovett
approved these changes
Apr 14, 2026
snowystinger
approved these changes
Apr 14, 2026
Member
|
I checked the equivalent TableView and ListView stories, they would have the same problem, but we pass a height to each of them at the root of the stories configuration. Remove that and add the resizing container, the ListView will also infinitely load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found during testing where the S2 async loading tree story continually loads new items even if you aren't scrolling to the bottom anymore which was caused by #9747
the root cause is because we now always render TreeView in a wrapper. in this particular story, the wrapper has no constrained height, so it expands to fit all its content and so we continually load more items.
the other alternative solution is to just fix the story and pass a height directly onto TreeView but it feels like there might be other people relying on the parent container to constrain the TreeView height
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the S2 async loading TreeView example and make sure it doesn't continuously load new items even when you aren't scrolled to the bottom
🧢 Your Project: