Skip to content

General Settings: Show language default label on date/time format options#11558

Open
sanketio wants to merge 1 commit intoWordPress:trunkfrom
sanketio:fix/64102
Open

General Settings: Show language default label on date/time format options#11558
sanketio wants to merge 1 commit intoWordPress:trunkfrom
sanketio:fix/64102

Conversation

@sanketio
Copy link
Copy Markdown

Summary

Adds a "(Language default)" label next to the date and time format option that matches the site's language on the General Settings screen, making it clear which format the active language expects.

Problem

When a site uses a non-English language, the pre-selected date/time format strings (e.g. F j, Y) are translated by WordPress core for that language. Previously, there was no visual indicator showing which radio option represented the language's natural default, leaving admins to guess.

A prior fix (changeset 60942) was reverted before WP 6.9 because it:

  1. Resolved the translated format using the user locale instead of the site locale, producing a wrong label when the two differed.
  2. Concatenated the label directly into the format string, breaking RTL layouts.

Solution

Before rendering the format list, the code now:

  1. Calls get_locale() to get the site locale (not the user locale).
  2. If the user is browsing in a different locale, temporarily switches to the site locale via switch_to_locale() / restore_previous_locale() to resolve the translated format strings.
  3. If switch_to_locale() returns false (locale already active, or language pack not installed), no label is shown — safe fallback, no label on a wrong format.

The label is rendered as a separate <span class="description"> element, outside the .format-i18n span, so existing JavaScript that reads the format preview text is completely unaffected.

Changes

File Description
src/wp-admin/options-general.php Locale-discovery block + conditional label in date and time format loops
tests/phpunit/tests/admin/optionsGeneral.php New PHPUnit test class (8 tests) covering locale-discovery logic and label output
tests/e2e/specs/general-settings-date-time-format.test.js New Playwright E2E tests (5 tests) verifying label visibility and HTML structure in-browser

Trac ticket: https://core.trac.wordpress.org/ticket/64102


Use of AI Tools

AI assistance: Yes
Tool(s): GitHub Copilot, ChatGPT
Model(s): GPT-5.1
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sanketparmar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant