General Settings: Show language default label on date/time format options#11558
General Settings: Show language default label on date/time format options#11558sanketio wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Summary
Adds a "(Language default)" label next to the date and time format option that matches the site's language on the General Settings screen, making it clear which format the active language expects.
Problem
When a site uses a non-English language, the pre-selected date/time format strings (e.g.
F j, Y) are translated by WordPress core for that language. Previously, there was no visual indicator showing which radio option represented the language's natural default, leaving admins to guess.A prior fix (changeset 60942) was reverted before WP 6.9 because it:
Solution
Before rendering the format list, the code now:
get_locale()to get the site locale (not the user locale).switch_to_locale()/restore_previous_locale()to resolve the translated format strings.switch_to_locale()returnsfalse(locale already active, or language pack not installed), no label is shown — safe fallback, no label on a wrong format.The label is rendered as a separate
<span class="description">element, outside the.format-i18nspan, so existing JavaScript that reads the format preview text is completely unaffected.Changes
src/wp-admin/options-general.phptests/phpunit/tests/admin/optionsGeneral.phptests/e2e/specs/general-settings-date-time-format.test.jsTrac ticket: https://core.trac.wordpress.org/ticket/64102
Use of AI Tools
AI assistance: Yes
Tool(s): GitHub Copilot, ChatGPT
Model(s): GPT-5.1
Used for: Initial code skeleton and test suggestions; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.