Open
Conversation
chrisstaite-menlo
force-pushed
the
no_canonical_relative
branch
2 times, most recently
from
fd6bf8b to
7cf972f
Compare
In #2237 the process path was canoncialised to work around the Rust stdlib instability when using current_dir. However, this breaks RBE where the program path changes the compiler behaviour. Update the builder to ensure that the arg0 remains relative even when the process path is resolved.
chrisstaite-menlo
force-pushed
the
no_canonical_relative
branch
from
7cf972f to
df706ee
Compare
Collaborator
|
Once this is worked out, we should cut v1.0.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #2237 the process path was canoncialised to work around the Rust stdlib instability when using current_dir. However, this breaks RBE where the program path changes the compiler behaviour.
Update the builder to ensure that the arg0 remains relative even when the process path is resolved.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
In the process of testing.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is