[DRAFT] Feature : Ability to solo or mute a clip from ClipView#3823
Draft
joxihan wants to merge 8 commits intoSynthstromAudible:communityfrom
Draft
[DRAFT] Feature : Ability to solo or mute a clip from ClipView#3823joxihan wants to merge 8 commits intoSynthstromAudible:communityfrom
joxihan wants to merge 8 commits intoSynthstromAudible:communityfrom
Conversation
Contributor
joxihan
commented
Jun 5, 2025
joxihan
commented
- Added community feature to be able to solo or mute a clip from its clipview.
- From Clip view :
- Press Horizontal Encoder + clip : solo or unsolo the active clip. Combine with Shift button to make it immediate.
- Press Vertical Encoder + clip : mute or unmute the active clip. Combine with Shift button to make it immediate.
Contributor
| #### <ins>Solo/Mute clip from ClipView</ins> | ||
|
|
||
| - Added community feature to be able to solo or mute a clip from its clip view : | ||
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. | |
| - :key[HORIZONTAL] + :key[CLIP]: solo or unsolo the active clip. Combine with Shift button to make it immediate. |
|
|
||
| - Added community feature to be able to solo or mute a clip from its clip view : | ||
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. | ||
| - Press `VERTICAL ENCODER ◀︎▶︎` + `CLIP` : mute or unmute the active clip. Combine with Shift button to make it immediate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Press `VERTICAL ENCODER ◀︎▶︎` + `CLIP` : mute or unmute the active clip. Combine with Shift button to make it immediate. | |
| - :key[VERTICAL] + :key[CLIP]: mute or unmute the active clip. Combine with Shift button to make it immediate. |
| #### 4.5.11 - Solo/Mute clip from ClipView | ||
|
|
||
| - (#3823) Added community feature to be able to solo or mute a clip from its clip view : | ||
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. | |
| - :key[HORIZONTAL] + :key[CLIP]: solo or unsolo the active clip. Combine with Shift button to make it immediate. |
|
|
||
| ### Clip View | ||
|
|
||
| #### <ins>Solo/Mute clip from ClipView</ins> |
Collaborator
There was a problem hiding this comment.
Suggested change
| #### <ins>Solo/Mute clip from ClipView</ins> | |
| #### <ins>Solo/Mute clip from Clip View</ins> |
|
|
||
| - (#3823) Added community feature to be able to solo or mute a clip from its clip view : | ||
| - Press `HORIZONTAL ENCODER ◀︎▶︎` + `CLIP`: solo or unsolo the active clip. Combine with Shift button to make it immediate. | ||
| - Press `VERTICAL ENCODER ◀︎▶︎` + `CLIP` : mute or unmute the active clip. Combine with Shift button to make it immediate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Press `VERTICAL ENCODER ◀︎▶︎` + `CLIP` : mute or unmute the active clip. Combine with Shift button to make it immediate. | |
| - :key[VERTICAL] + :key[CLIP]: mute or unmute the active clip. Combine with Shift button to make it immediate. |
| } | ||
| } | ||
| if (on && currentUIMode == UI_MODE_NONE) { | ||
|
|
| // Clip view button | ||
| else if (b == CLIP_VIEW) { | ||
| D_PRINTLN("InstrumentClipView::buttonAction(CLIP_VIEW) %d", (int)b); | ||
| if (on) { |
Collaborator
There was a problem hiding this comment.
Is it possible to move this below the "D_PRINTLN("- yes");" line?
So you would have something like:
if (Buttons::isButtonPressed(deluge::hid::button::X_ENC)
|| Buttons::isButtonPressed(deluge::hid::button::Y_ENC)) {
--> solo or mute
else
-> change root UI to automation view
seangoodvibes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.