[DRAFT] display identified sample pitch, allow editing it#3786
Closed
nikodemus wants to merge 1 commit intoSynthstromAudible:communityfrom
Closed
[DRAFT] display identified sample pitch, allow editing it#3786nikodemus wants to merge 1 commit intoSynthstromAudible:communityfrom
nikodemus wants to merge 1 commit intoSynthstromAudible:communityfrom
Conversation
Contributor
|
This is an excellent idea, really essential for working with imported samples. |
nikodemus
force-pushed
the
pr-display-sample-pitch
branch
4 times, most recently
from
b419451 to
ce19df2
Compare
- In multirange display, display the identified pitch of the sample after the range as (NOTE+CENTS), both editable. - The column buttons can be used to select the editable value in addition to the horizontal encoder, making the UI more consistent on OLED. - 7-segment display of multisample ranges has been overhauled. Only the low end of each note range is displayed initially: use horizontal encoder or the column buttons to view & edit other columns. - BOTTOM and TOP in the note range renamed to LOW and HIGH (LO and HI for 7-seg) so that NOTE-NOTE (NOTE+CT) information fits onto OLED screen. - MenuItem::drawItemsForOled has an additional startX parameter, allowing the default 1-character wide left-padding to be removed, necessary to make the expanded MultiRange fit without scrolling. - SampleHolderForVoice::cents made protected, so finetuning cannot be accidentally be forgotten. - TODO: it's not 100% clear to me yet how the different transpose controls relate to different sample types - figure it out and make sure it works correctly. (It probably does, but I want to know.)
nikodemus
force-pushed
the
pr-display-sample-pitch
branch
from
ce19df2 to
a1c6ea2
Compare
Collaborator
Author
|
Closing this one, reopening one for main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multirange display, display the identified pitch of the sample after the range as (NOTE+CENTS), both editable.
The column buttons can be used to select the editable value in addition to the horizontal encoder, making the UI more consistent on OLED.
7-segment display of multisample ranges has been overhauled. Only the low end of each note range is displayed initially: use horizontal encoder or the column buttons to view & edit other columns.
BOTTOM and TOP in the note range renamed to LOW and HIGH (LO and HI for 7-seg) so that NOTE-NOTE (NOTE+CT) information fits onto OLED screen.
MenuItem::drawItemsForOled has an additional startX parameter, allowing the default 1-character wide left-padding to be removed, necessary to make the expanded MultiRange fit without scrolling.
SampleHolderForVoice::cents made protected, so finetuning cannot be accidentally be forgotten.
TODO: it's not 100% clear to me yet how the different transpose controls relate to different sample types - figure it out and make sure it works correctly. (It probably does, but I want to know.)