Round tool stats display to 1 decimal#2872
Open
GasSpace630 wants to merge 5 commits intoPixelGuys:masterfrom
Open
Round tool stats display to 1 decimal#2872GasSpace630 wants to merge 5 commits intoPixelGuys:masterfrom
GasSpace630 wants to merge 5 commits intoPixelGuys:masterfrom
Conversation
IntegratedQuantum
requested changes
Apr 11, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Also please rebase, there was a refactor that affects this.
GasSpace630
force-pushed
the
round-tool-stats
branch
from
2069748 to
591efd6
Compare
IntegratedQuantum
requested changes
Apr 11, 2026
| proceduralItem.getProperty(property.destination orelse continue).* += sum; | ||
| } | ||
| if (proceduralItem.damage < 1) proceduralItem.damage = 1/(2 - proceduralItem.damage); | ||
| if (proceduralItem.swingSpeed < 1) proceduralItem.swingSpeed = 1/(2 - proceduralItem.swingSpeed); |
Member
There was a problem hiding this comment.
Why did you remove this? This is required to prevent negative values.
Member
|
also CI failed, please run the formatter |
IntegratedQuantum
requested changes
Apr 15, 2026
Member
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Now you are only applying rounding to small and negative values, and they remain negative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #2871 which fixes #2696
The previous PR contained unrelated changes, so it was closed.
This version only includes the formatting changes.