Skip to content

fix(protocol-designer): center single channel pipette in reservoirs#21242

Merged
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
RQA-5320
Apr 13, 2026
Merged

fix(protocol-designer): center single channel pipette in reservoirs#21242
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
RQA-5320

Conversation

@rclarke0
Copy link
Copy Markdown
Contributor

@rclarke0 rclarke0 commented Apr 9, 2026

Overview

Center single channel pipette shadow in rectangular wells

Previously, the shadow was going to the wells exact location. This is correct in most cases, but for reservoir troughs, the 1ch pipette should go to the center of the trough.

Test Plan and Hands on Testing

  • smoke tested with protocol attached in RQA-5320
Screenshot 2026-04-09 at 4 50 36 PM

Changelog

  • when using getHoveredOffsetFromWell divide wellY position by 2 when a single channel pipette being used.

Review requests

  • any other instances where custom positioning would be needed?

Risk assessment

  • low - cosmetic

closes RQA-5320

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.29%. Comparing base (d23799b) to head (ff91d24).
⚠️ Report is 1 commits behind head on chore_release-pd-8.10.0.

Files with missing lines Patch % Lines
...StepForm/PipetteFields/TipSelectionWizard/utils.ts 0.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           chore_release-pd-8.10.0   #21242      +/-   ##
===========================================================
- Coverage                    55.29%   55.29%   -0.01%     
===========================================================
  Files                         4003     4003              
  Lines                       339075   339079       +4     
  Branches                     51844    51843       -1     
===========================================================
  Hits                        187490   187490              
- Misses                      151367   151371       +4     
  Partials                       218      218              
Flag Coverage Δ
protocol-designer 19.96% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...StepForm/PipetteFields/TipSelectionWizard/utils.ts 22.28% <0.00%> (-0.24%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good assuming successful smoke testing for round wells/>1 channel pipettes and passing CI

const wellHeight = labwareHasOneRowAndIsRectangular ? well.yDimension : well.y
const wellX = well.x + xOffset
const wellY = wellHeight + yOffset
const singleChannelPipette = pipetteSpec.channels === 1
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const singleChannelPipette = pipetteSpec.channels === 1
const isSingleChannelPipette = pipetteSpec.channels === 1

@rclarke0 rclarke0 merged commit 8deddbc into chore_release-pd-8.10.0 Apr 13, 2026
17 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants