fix(protocol-designer): center single channel pipette in reservoirs#21242
Merged
rclarke0 merged 4 commits intochore_release-pd-8.10.0from Apr 13, 2026
Merged
fix(protocol-designer): center single channel pipette in reservoirs#21242rclarke0 merged 4 commits intochore_release-pd-8.10.0from
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.10.0 #21242 +/- ##
===========================================================
- Coverage 55.29% 55.29% -0.01%
===========================================================
Files 4003 4003
Lines 339075 339079 +4
Branches 51844 51843 -1
===========================================================
Hits 187490 187490
- Misses 151367 151371 +4
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ncdiehl11
reviewed
Apr 10, 2026
| const wellHeight = labwareHasOneRowAndIsRectangular ? well.yDimension : well.y | ||
| const wellX = well.x + xOffset | ||
| const wellY = wellHeight + yOffset | ||
| const singleChannelPipette = pipetteSpec.channels === 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| const singleChannelPipette = pipetteSpec.channels === 1 | |
| const isSingleChannelPipette = pipetteSpec.channels === 1 |
ncdiehl11
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Center single channel pipette shadow in rectangular wells
Previously, the shadow was going to the wells exact location. This is correct in most cases, but for reservoir troughs, the 1ch pipette should go to the center of the trough.
Test Plan and Hands on Testing
Changelog
getHoveredOffsetFromWelldivide wellY position by 2 when a single channel pipette being used.Review requests
Risk assessment
closes RQA-5320