fix(protocol-designer): ensure 8.5 protocols have submerge and retract speeds when migrating

[rclarke0]

Overview

Ensure 8.5.0 protocols made in protocol designer have submerge and retract speeds.

The 8.5 protocol attached in AUTH-2828 was missing submerge and retract speed args in the transfer_with_liquid_class and raising an error during analysis

Test Plan and Hands on Testing

• upload .json protocol attached in AUTH-2828, migrated, and exported and ran in 9.0.0 app without error
• checked to confirm that default max speeds had been added to the transfer steps

Changelog

• added an additional migration to 8_5_5. If there are no submerge or retract speeds already in the file, it will use the calculated defaults depending on pipette and robot type

Review requests

• not sure why the 8.5 protocol would not have submerge speeds considering it is included in the 8_5 migration? but this fix will prevent future migrated 8.5 protocols from missing them

Risk assessment

low

closes AUTH-2828

[codecov]

Codecov Report

❌ Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.46%. Comparing base (c89699b) to head (81331a3).
⚠️ Report is 9 commits behind head on chore_release-pd-8.10.0.

Files with missing lines	Patch %	Lines
protocol-designer/src/load-file/migration/8_5_5.ts	5.26%	18 Missing ⚠️

Additional details and impacted files

@@                     Coverage Diff                     @@
##           chore_release-pd-8.10.0   #21231      +/-   ##
===========================================================
- Coverage                    55.47%   55.46%   -0.01%     
===========================================================
  Files                         4003     4003              
  Lines                       339040   339055      +15     
  Branches                     51847    51847              
===========================================================
+ Hits                        188072   188073       +1     
- Misses                      150745   150759      +14     
  Partials                       223      223              

Flag	Coverage Δ
protocol-designer	19.96% <5.26%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
protocol-designer/src/load-file/migration/8_5_5.ts	5.08% <5.26%> (+0.53%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jerader]

i'm trying to wrap my brain around why this error occurred with that one protocol. Any ideas? PD 8.5.0 should have introduced all those missing fields, so I don't get why this protocol doesn't have them to begin with.

[rclarke0]

i'm trying to wrap my brain around why this error occurred with that one protocol. Any ideas? PD 8.5.0 should have introduced all those missing fields, so I don't get why this protocol doesn't have them to begin with.

the fields exist in the .json protocol but they are set to null. When I downgraded the .json protocol to 8.4 the values got updated upon exporting so I'm not really sure either

[jerader]

i'm trying to wrap my brain around why this error occurred with that one protocol. Any ideas? PD 8.5.0 should have introduced all those missing fields, so I don't get why this protocol doesn't have them to begin with.

the fields exist in the .json protocol but they are set to null. When I downgraded the .json protocol to 8.4 the values got updated upon exporting so I'm not really sure either

Cool, i am a bit hesitant to merge this in since we aren't sure of the exact root of why the protocol failed to begin with. If we can't figure it out in the next few days, we should just punt the ticket for a future release 😄

[rclarke0]

#18258 this has already been done