docs(protocol-designer): PD 8.10 manual revisions#21177
docs(protocol-designer): PD 8.10 manual revisions#21177emilyburghardt wants to merge 9 commits intochore_release-pd-8.10.0from
Conversation
jwwojak
left a comment
There was a problem hiding this comment.
Mostly some broad comments vs specific line edits.
I'm confused by referring to UI sections as "forms." It might be difficult for a reader to keep a count in their head (I'm on form 1 or form 2, maybe it's form 3). Instead, try to associate a process with a descriptive label, particularly if the UI has a label for different sections.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.10.0 #21177 +/- ##
===========================================================
- Coverage 55.32% 55.31% -0.01%
===========================================================
Files 4004 4004
Lines 339099 339099
Branches 51858 51878 +20
===========================================================
- Hits 187602 187576 -26
- Misses 151279 151305 +26
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
rclarke0
left a comment
There was a problem hiding this comment.
agree with Joe's comments as well!
ecormany
left a comment
There was a problem hiding this comment.
A few copy suggestions, including a handful of typos that should definitely get fixed. In general, the additions are great!
Overview
Test Plan and Hands on Testing
sandbox
Changelog
transfer.mda bit (it's getting pretty long) to add more sections that better separate the choices users have to make, and reflect the order of those choices in PD.Review requests
Need to decide on nozzle naming to use in the PD manual. Either A) match PAPI nozzle naming exactly or B) differentiate slightly, because PD never shows the values we'll refer to
is everything else clear?
Risk assessment
low.