fix: IndexError with columns full of NaNs #1869
Open
lecardozo wants to merge 2 commits intoNVIDIA-Merlin:mainfrom
Open
fix: IndexError with columns full of NaNs #1869lecardozo wants to merge 2 commits intoNVIDIA-Merlin:mainfrom
lecardozo wants to merge 2 commits intoNVIDIA-Merlin:mainfrom
Conversation
Contributor
|
/ok to test |
Contributor
|
tests are running via an internal PR here #1870 |
jperez999
approved these changes
Oct 31, 2023
Author
|
@jperez999 checked the GPU CI workflow and it seems like it was canceled externally (maybe it reached a timeout?). Let me know if there's anything I should/need to do to solve that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1865
The error reported there was caused by an indexing on an empty series. To work around that, we are adding a pre-condition to check whether the series after
dropna()is empty, so we don't try to check its first element.