gas data tests across execution entry points#26179
Merged
dariorussi merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
dariorussi
requested review from
alex-mysten,
aschran,
cgswords,
mystenmark,
tnowacki and
tzakian
dariorussi
force-pushed
the
dario/gas_tests
branch
from
36044db to
e8f18cb
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
approved these changes
Apr 10, 2026
Contributor
tzakian
left a comment
tzakian
left a comment
There was a problem hiding this comment.
One question on a test but otherwise LGTM
| } | ||
| _ => unreachable!(), | ||
| }; | ||
| println!("{entry_point}: {result:?}"); |
Contributor
There was a problem hiding this comment.
Should there be an assertion on the result here?
Contributor
Author
There was a problem hiding this comment.
well definitely there should NOT be a println
alex-mysten
approved these changes
Apr 10, 2026
Contributor
alex-mysten
left a comment
alex-mysten
left a comment
There was a problem hiding this comment.
This looks good to me - one comment - happy to add the address balance / gasless variants once merged
| // ============================================================================= | ||
|
|
||
| #[tokio::test] | ||
| async fn test_simple_transfer_gas_all_paths() { |
Contributor
There was a problem hiding this comment.
what about a valid gas coin with insufficient balance for gas_budget? thinking about how that would translate to address balances too
Contributor
Author
There was a problem hiding this comment.
we should have those tests elsewhere, this was mostly to track bad gas data and transaction data related to gas.
To be honest I would like to review all gas tests because we had few issues and I believe we can organize them better
dariorussi
force-pushed
the
dario/gas_tests
branch
from
e8f18cb to
3a8e587
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Contributor
Author
|
addressed feedback |
dariorussi
force-pushed
the
dario/gas_tests
branch
from
3a8e587 to
8aad53b
Compare
dariorussi
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Description We check that bad gas data produces expected and consistent results across entry point. Bogus data for address balance and free transaction is not really exercised yet and should come with a later PR (@mystenmark @alex-mysten @aschran if you have suggestions) Co-Authored-By: My Dog (1M bones) <noreply@my_dog.com> and Claude Opus 4.6 (1M context) <noreply@anthropic.com> ## Test plan This is it --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] Indexing Framework:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We check that bad gas data produces expected and consistent results across entry point.
Bogus data for address balance and free transaction is not really exercised yet and should come with a later PR (@mystenmark @alex-mysten @aschran if you have suggestions)
Co-Authored-By: My Dog (1M bones) <noreply@my_dog.com> and Claude Opus 4.6 (1M context) noreply@anthropic.com
Test plan
This is it
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.