[light-client] trust ratcheting perf improvements#26173
Open
alex-mysten wants to merge 1 commit intomainfrom
Open
[light-client] trust ratcheting perf improvements#26173alex-mysten wants to merge 1 commit intomainfrom
alex-mysten wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0f20ef5 to
18a7def
Compare
18a7def to
3425b10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors trust ratcheting in the authenticated events light client:
parallel_fetch_epoch_data(buffer_unordered, concurrency 20), driven by a target epoch extracted from the proof response's certified summary.epoch_cachemutex across the entire ratchet (including network fetches). Concurrent ratchet calls now serialize: the first does the work and the rest see the cache already advanced and return immediately. Removes the previous skip-and-fresh-read dance.summary.bcsandsignaturefrom the ledger service (instead of fullCheckpointwithcontents), and buildsCertifiedCheckpointSummarydirectly vianew_from_data_and_sigrather than going throughfull_checkpoint_content::Checkpoint(which requires contents to construct).Arc<Committee>inEpochCacheto avoid expensive committee clones on every lookup.httpsRPC URLs.MAX_RATCHET_GAP = 10_000epochs (≈27 years) to bound work induced by malformed server responses.Test plan
cargo nextest run -p sui-light-client(29 passed)cargo simtest -p sui-e2e-tests --test authenticated_events_client_test(12 passed, includingtest_client_cross_epoch_stream)cargo xclippy -D warningscargo fmt --all