Add signTypedData address recovery test (#2019)#2260
Open
Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Open
Add signTypedData address recovery test (#2019)#2260Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a focused unit test to demonstrate and verify how to recover the signer address from a signTypedData signature.
Specifically:
SignTest.Sign.signTypedData(...).StructuredDataEncoder.hashStructuredData().Sign.signedMessageHashToKey(...).SampleKeys.ADDRESSWhere should the reviewer start?
Start in
crypto/src/test/java/org/web3j/crypto/SignTest.java, especially:The new typed-data fixture constant near the top of the class.
testRecoverAddressFromSignTypedData()for the recovery flow.testSignTypedData()which now reuses the shared fixture.Why is it needed?
Issue #2019 identifies a real gap: while signTypedData signing is tested, recovery/verification flow is not clearly demonstrated in tests.
This PR closes that gap by adding an executable example that:
Checklist