Fix raw EthLog.LogResult generic usages (#2252)#2259
Closed
Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Closed
Fix raw EthLog.LogResult generic usages (#2252)#2259Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Sukuna0007Abhi wants to merge 1 commit intoLFDT-web3j:mainfrom
Conversation
Signed-off-by: Sukuna0007Abhi <appsonly310@gmail.com>
Sukuna0007Abhi
requested review from
NickSneo,
conor10 and
gtebrean
as code owners
Contributor
|
fixed with #2254 already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue #2252 by removing raw EthLog.LogResult generic usages and replacing them with wildcard-parameterized types across EthLog response handling, filter APIs/implementations, and affected tests.
Where should the reviewer start?
Start with core/src/main/java/org/web3j/protocol/core/methods/response/EthLog.java, then review filter contract and implementations in:
core/src/main/java/org/web3j/protocol/core/filters/Filter.java,
core/src/main/java/org/web3j/protocol/core/filters/BlockFilter.java,
core/src/main/java/org/web3j/protocol/core/filters/BlocksFilter.java,
core/src/main/java/org/web3j/protocol/core/filters/LogFilter.java,
core/src/main/java/org/web3j/protocol/core/filters/LogsFilter.java,
core/src/main/java/org/web3j/protocol/core/filters/PendingTransactionFilter.java,
core/src/main/java/org/web3j/protocol/core/filters/PendingTransactionsFilter.java.
Why is it needed?
Raw generic usage of EthLog.LogResult produces IDE/compiler warnings and weakens type safety. Parameterizing these usages improves API clarity and developer experience without changing runtime behavior.
Checklist