Add User Cancel Event to Journal, Server cancel replaced with Abort#1089
Add User Cancel Event to Journal, Server cancel replaced with Abort#1089Dym03 wants to merge 1 commit intoIt4innovations:mainfrom
Conversation
f6a1136 to
32a3882
Compare
|
Updated test so it matches the new aborted state. |
|
LGTM.
|
|
Okey, will look at the colorway. And update the documentation. Also there are some minor bugs of Abort, that will be fixed. |
f34dcb0 to
4e8013f
Compare
4e8013f to
71018af
Compare
spirali
left a comment
There was a problem hiding this comment.
I like the final colors.
I have just put one change request to the documentation; otherwise it is ready to merge.
| | | | | | ||
| v v v v | ||
| Finished Failed Canceled Aborted | ||
| ``` |
There was a problem hiding this comment.
Change just to:
Waiting--------------------\
| ^ |
| | |
v | |
Running--------------------|
| | |
| \--------\ |
| | |
v v v
Finished Failed Canceled/Aborted
71018af to
328c72d
Compare
|
Documentation updated, I think with this merged the #1001 can be closed. And maybe new Issue can be opened to capture the thought about the distuguish of the Abort due to Dependency/ Abort due to crash of worker | due to max fails. I have found 2 more things that needs an update, so I will update them later today. |
328c72d to
4ee7a47
Compare
|
Updated documentation about the addition of the Aborted state also in the Job, to keep the original idea of propagating the task state to the Job state. But it is also mentioned in the documentation that this shouldn't happen as aborted state is closely connected to the failure of the task, which would imply that this Job State shouldn't be reached, in the current state. |

This PR finishes work on #1001 with the addition of JobCancel event into the Journal. Also this PR introduces difference between cancellation of Task made by user and
hq, as was suggested by @spirali so canceled tasks are canceled by user and aborted tasks are canceled by thehq.I would like to hear your opinion if the colors suggested are okay with you
create_dataset(&aborted, "Aborted", Color::LightCyan)andDashboardTaskState::Aborted => Color::LightCyanExample below:
Documentation:
I will update the documentation once I get agreement that this state is wanted
Sorry for not dividing it into a smaller chunk, like only the addition of the JobCancel, but while I was at it, I just took a shot at doing it at once :P.