DomNode: fix insertBefore() not dissolving DocumentFragment#1110
Open
duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
Open
DomNode: fix insertBefore() not dissolving DocumentFragment#1110duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
duonglaiquang wants to merge 1 commit intoHtmlUnit:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###This PR does the following
Fix
DomNode.insertBefore(DomNode)to dissolveDocumentFragmentinto its children before insertionProblem
The
DomNode.insertBefore(DomNode)did not check forDomDocumentFragment. When aDocumentFragmentwas passed, the fragment node itself was inserted into the DOM tree instead of being dissolved into its children.This caused
before(),after(),prepend(), and multi-argreplaceWith()to produce incorrect DOM structures.