Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PQ Digest to the existing “SYSTEM SETTINGS” settings-management flow in SystemCenter by wiring up a new backend settings endpoint/table and exposing it in the UI navigation and settings router. Also updates the PR template and applies minor navbar ordering/label tweaks.
Changes:
- Add
PQDigestSettingmodel/controller mapping toPQDigest.Settingand exposeapi/PQDigest/Setting. - Add Redux slice + settings-page routing support for
System=PQDigest. - Update navigation to include “PQ Digest” under SYSTEM SETTINGS; update PR template wording/format.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/SystemCenter.tsx | Adds PQ Digest entry under SYSTEM SETTINGS; minor nav ordering/label tweaks. |
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Store/Store.ts | Introduces PQDigestSettingSlice and registers reducer. |
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Settings/BySetting.tsx | Adds PQDigest option to settings switch/union and routes to new slice. |
| Source/Applications/SystemCenter/wwwroot/Scripts/TSX/SystemCenter/Matcher.tsx | Allows System=PQDigest for the Settings route. |
| Source/Applications/SystemCenter/SystemCenter.csproj | Includes new Model\\PQDigestSetting.cs in compilation. |
| Source/Applications/SystemCenter/Model/PQDigestSetting.cs | New model/controller mapping to PQDigest.Setting + api/PQDigest/Setting. |
| .github/pull_request_template.md | Simplifies PR template content/structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Erika Wills <elwills@gridprotectionalliance.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Erika Wills <elwills@gridprotectionalliance.org>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Erika Wills <elwills@gridprotectionalliance.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Issue(s)
SC-368
Description
Add a page to manage PQ Digest settings.
Update PR template.
Update navbar nitpicks.
How/Where to test OR Detail how it was tested
Related PRs
n/a