fix(agent-client): handle missing layout in hook responses#1540
Open
fix(agent-client): handle missing layout in hook responses#1540
Conversation
…ge responses
When the backend returns a response without a layout field (e.g. domain
service actions returning only { fields: [...] }), loadInitialState and
loadChanges crash with "queryResults.layout is not iterable".
Default to empty array when layout is missing.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layoutfield (e.g. domain service actions returning only{ fields: [...] }),loadInitialStateandloadChangescrash withqueryResults.layout is not iterablelayoutto[]when missing in bothloadInitialStateandloadChangesTest plan
🤖 Generated with Claude Code
Note
Fix crash in
FieldFormStateswhen hook responses omit the layout propertyIn
field-form-states.ts, spreadingundefinedon the internal layout array caused a runtime error when load or change hook responses did not include alayoutproperty. BothloadInitialStateandsetFieldValuenow fall back to an empty array whenlayoutis absent, leaving the internal layout empty rather than throwing.Macroscope summarized 53f9e58.