Skip to content

London | 26-ITP-Jan | Asha Ahmed | Sprint 2 | Book Library#421

Open
ashaahmed7 wants to merge 2 commits intoCodeYourFuture:mainfrom
ashaahmed7:book-library
Open

London | 26-ITP-Jan | Asha Ahmed | Sprint 2 | Book Library#421
ashaahmed7 wants to merge 2 commits intoCodeYourFuture:mainfrom
ashaahmed7:book-library

Conversation

@ashaahmed7
Copy link
Copy Markdown

@ashaahmed7 ashaahmed7 commented Apr 11, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I fixed the bugs in the code and corrected the syntax

Questions

N/A

@ashaahmed7 ashaahmed7 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 11, 2026
@Luro91 Luro91 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 12, 2026
Copy link
Copy Markdown

@Luro91 Luro91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I run the project?

When I open the html file in the browser I get this error:
index.html:1 Access to script at Module-Data-Flows/debugging/book-library/script.js' from origin 'null' has been blocked by CORS policy: Cross origin requests are only supported for protocol schemes: chrome, chrome-extension, chrome-untrusted, data, http, https, isolated-app. script.js:1 Failed to load resource: net::ERR_FAILED index.html:1 Unsafe attempt to load URL file://Module-Data-Flows/debugging/book-library/index.html from frame with URL file:///Module-Data-Flows/debugging/book-library/index.html. 'file:' URLs are treated as unique security origins.

.form-group {
width: 400px;
height: 300px;
align-self: left;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

THe commit messages "Refactor input validation and improve book submission logic in script.js" does not make this clear to me

pagesCount <= 0
) {
alert("Please fill all fields!");
alert(
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce error handling

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants