Conversation
06a6228 to
367ce22
Compare
|
@Dakuan I have started the AI code review. It will take a few minutes to complete. |
27d172c to
866e244
Compare
There was a problem hiding this comment.
1 issue found across 11 files
Confidence score: 4/5
- This PR is likely safe to merge, with one moderate issue:
packages/server/src/ai/tools/budibase/knowledgeFiles.tsappears to computetotaland status counts from filtered matches instead of all attached files. - Impact is mainly reporting accuracy (incorrect totals/status breakdown), which can mislead users but is unlikely to break core functionality, so risk stays moderate rather than high.
- Given the single 5/10 issue and otherwise limited evidence of broader regressions, merge risk looks minimal-to-moderate overall.
- Pay close attention to
packages/server/src/ai/tools/budibase/knowledgeFiles.ts- ensuretotaland status counts are derived from all attached files, not only filtered results.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/server/src/ai/tools/budibase/knowledgeFiles.ts">
<violation number="1" location="packages/server/src/ai/tools/budibase/knowledgeFiles.ts:233">
P2: Compute `total` and the status counts from all attached files, not just the filtered matches.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
|
|
||
| return { | ||
| matchedCount: metadata.length, | ||
| total: metadata.length, |
There was a problem hiding this comment.
P2: Compute total and the status counts from all attached files, not just the filtered matches.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/server/src/ai/tools/budibase/knowledgeFiles.ts, line 233:
<comment>Compute `total` and the status counts from all attached files, not just the filtered matches.</comment>
<file context>
@@ -0,0 +1,250 @@
+
+ return {
+ matchedCount: metadata.length,
+ total: metadata.length,
+ ambiguous: isAmbiguous,
+ bestMatch,
</file context>
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/server/src/automations/tests/steps/getRow.spec.ts">
<violation number="1" location="packages/server/src/automations/tests/steps/getRow.spec.ts:15">
P2: Add a matching `automation.shutdown()` in `afterAll`; this new `automation.init()` starts a long-lived queue worker and now leaves it running after the spec finishes.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
ca49532 to
f5b882b
Compare
adrinr
left a comment
There was a problem hiding this comment.
Not sure if this should be the default behaviour... This might leak some information to the end user
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/server/src/api/controllers/ai/chatConversations.ts">
<violation number="1" location="packages/server/src/api/controllers/ai/chatConversations.ts:448">
P2: Only suppress `ragSources` after a successful `list_knowledge_files` result. Marking the flag at tool-call time hides sources even when the tool fails.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
adrinr
left a comment
There was a problem hiding this comment.
Really nice job. And it's great to see so many tests :)
| if (!agentId) { | ||
| throw new Error("Agent _id is required") | ||
| } | ||
| const hasKnowledgeBases = agent.knowledgeBases?.some(Boolean) ?? false |
There was a problem hiding this comment.
Why this instead of just the classic agent.knowledgeBases?.length?

Description
note: real struggle getting the tests to pass, related to resolving workspace ID turned into a whackmole game where Id fix one test and then another would fail. Probably exposing 'just so' test scaffolding existing before.Screenshots
Screen.Recording.2026-04-10.at.10.43.54.mov