fix: add throw keyword before logger.throw() for TypeScript control flow

TypeScript doesn't narrow types after `logger.CODE().throw()` because
the return type inference doesn't propagate `never` through the chained
call. Adding `throw` before the expression fixes control flow analysis.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: antfu

packages/core/src/node/context.ts

@@ -167,7 +167,7 @@ export async function createDevToolsContext(
       await plugin.devtools?.setup?.(context)
     }
     catch (error) {
-      logger.DTK0014({ name: plugin.name }, { cause: error }).throw()
+      throw logger.DTK0014({ name: plugin.name }, { cause: error }).throw()
     }
   }
 

packages/core/src/node/host-commands.ts

@@ -12,7 +12,7 @@ export class DevToolsCommandsHost implements DevToolsCommandsHostType {
 
   register(command: DevToolsServerCommandInput): DevToolsCommandHandle {
     if (this.commands.has(command.id)) {
-      logger.DTK0024({ id: command.id }).throw()
+      throw logger.DTK0024({ id: command.id }).throw()
     }
     this.commands.set(command.id, command)
     this.events.emit('command:registered', this.toSerializable(command))
@@ -21,11 +21,11 @@ export class DevToolsCommandsHost implements DevToolsCommandsHostType {
       id: command.id,
       update: (patch: Partial<Omit<DevToolsServerCommandInput, 'id'>>) => {
         if ('id' in patch) {
-          logger.DTK0025().throw()
+          throw logger.DTK0025().throw()
         }
         const existing = this.commands.get(command.id)
         if (!existing) {
-          logger.DTK0026({ id: command.id }).throw()
+          throw logger.DTK0026({ id: command.id }).throw()
         }
         Object.assign(existing, patch)
         this.events.emit('command:registered', this.toSerializable(existing))
@@ -45,7 +45,7 @@ export class DevToolsCommandsHost implements DevToolsCommandsHostType {
   async execute(id: string, ...args: any[]): Promise<unknown> {
     const found = this.findCommand(id)
     if (!found) {
-      logger.DTK0026({ id }).throw()
+      throw logger.DTK0026({ id }).throw()
     }
     if (!found.handler) {
       throw new Error(`Command "${id}" has no handler (group-only command)`)

packages/core/src/node/host-docks.ts

@@ -73,15 +73,15 @@ export class DevToolsDockHost implements DevToolsDockHostType {
     update: (patch: Partial<T>) => void
   } {
     if (this.views.has(view.id) && !force) {
-      logger.DTK0015({ id: view.id }).throw()
+      throw logger.DTK0015({ id: view.id }).throw()
     }
     this.views.set(view.id, view)
     this.events.emit('dock:entry:updated', view)
 
     return {
       update: (patch) => {
         if (patch.id && patch.id !== view.id) {
-          logger.DTK0016().throw()
+          throw logger.DTK0016().throw()
         }
         this.update(Object.assign(this.views.get(view.id)!, patch))
       },
@@ -90,7 +90,7 @@ export class DevToolsDockHost implements DevToolsDockHostType {
 
   update(view: DevToolsDockUserEntry): void {
     if (!this.views.has(view.id)) {
-      logger.DTK0017({ id: view.id }).throw()
+      throw logger.DTK0017({ id: view.id }).throw()
     }
     this.views.set(view.id, view)
     this.events.emit('dock:entry:updated', view)

packages/core/src/node/host-functions.ts

@@ -31,7 +31,7 @@ export class RpcFunctionsHost extends RpcFunctionsCollectorBase<DevToolsRpcServe
     ...args: Args
   ): Promise<Awaited<ReturnType<DevToolsRpcServerFunctions[T]>>> {
     if (!this.definitions.has(method as string)) {
-      logger.DTK0020({ name: String(method) }).throw()
+      throw logger.DTK0020({ name: String(method) }).throw()
     }
 
     const handler = await this.getHandler(method)
@@ -66,7 +66,7 @@ export class RpcFunctionsHost extends RpcFunctionsCollectorBase<DevToolsRpcServe
 
   getCurrentRpcSession(): DevToolsNodeRpcSession | undefined {
     if (!this._asyncStorage)
-      logger.DTK0021().throw()
+      throw logger.DTK0021().throw()
     return this._asyncStorage.getStore()
   }
 }

packages/core/src/node/host-terminals.ts

@@ -20,7 +20,7 @@ export class DevToolsTerminalHost implements DevToolsTerminalHostType {
 
   register(session: DevToolsTerminalSession): DevToolsTerminalSession {
     if (this.sessions.has(session.id)) {
-      logger.DTK0018({ id: session.id }).throw()
+      throw logger.DTK0018({ id: session.id }).throw()
     }
     this.sessions.set(session.id, session)
     this.bindStream(session)
@@ -30,7 +30,7 @@ export class DevToolsTerminalHost implements DevToolsTerminalHostType {
 
   update(patch: PartialWithoutId<DevToolsTerminalSession>): void {
     if (!this.sessions.has(patch.id)) {
-      logger.DTK0019({ id: patch.id }).throw()
+      throw logger.DTK0019({ id: patch.id }).throw()
     }
     const session = this.sessions.get(patch.id)!
     Object.assign(session, patch)
@@ -85,7 +85,7 @@ export class DevToolsTerminalHost implements DevToolsTerminalHostType {
     terminal: Omit<DevToolsTerminalSessionBase, 'status'>,
   ): Promise<DevToolsChildProcessTerminalSession> {
     if (this.sessions.has(terminal.id)) {
-      logger.DTK0018({ id: terminal.id }).throw()
+      throw logger.DTK0018({ id: terminal.id }).throw()
     }
     const { exec } = await import('tinyexec')
 

packages/core/src/node/host-views.ts

@@ -16,14 +16,14 @@ export class DevToolsViewHost implements DevToolsViewHostType {
 
   hostStatic(baseUrl: string, distDir: string) {
     if (!existsSync(distDir)) {
-      logger.DTK0022({ distDir }).throw()
+      throw logger.DTK0022({ distDir }).throw()
     }
 
     this.buildStaticDirs.push({ baseUrl, distDir })
 
     if (this.context.viteConfig.command === 'serve') {
       if (!this.context.viteServer)
-        logger.DTK0023().throw()
+        throw logger.DTK0023().throw()
       this.context.viteServer.middlewares.use(
         baseUrl,
         sirv(distDir, {

packages/core/src/node/rpc-shared-state.ts

@@ -48,7 +48,7 @@ export function createRpcSharedStateServerHost(
         return sharedState.get(key)!
       }
       if (options?.initialValue === undefined && options?.sharedState === undefined) {
-        logger.DTK0027({ key }).throw()
+        throw logger.DTK0027({ key }).throw()
       }
       debug('new-state', key)
       const state = options.sharedState ?? createSharedState<T>({

packages/core/src/node/rpc/internal/docks-on-launch.ts

@@ -14,10 +14,10 @@ export const docksOnLaunch = defineRpcFunction({
 
         const entry = context.docks.values().find(entry => entry.id === entryId)
         if (!entry) {
-          logger.DTK0030({ id: entryId }).throw()
+          throw logger.DTK0030({ id: entryId }).throw()
         }
         if (entry.type !== 'launcher') {
-          logger.DTK0031({ id: entryId }).throw()
+          throw logger.DTK0031({ id: entryId }).throw()
         }
         try {
           context.docks.update({

packages/core/src/node/rpc/public/open-in-editor.ts

@@ -13,7 +13,7 @@ export const openInEditor = defineRpcFunction({
 
         // Prevent escaping the workspace root
         if (rel.startsWith('..') || rel.includes('\0')) {
-          logger.DTK0028().throw()
+          throw logger.DTK0028().throw()
         }
 
         await import('launch-editor').then(r => r.default(resolved))

packages/core/src/node/rpc/public/open-in-finder.ts

@@ -13,7 +13,7 @@ export const openInFinder = defineRpcFunction({
 
         // Ensure the path stays within workspace root
         if (rel.startsWith('..') || rel.includes('\0')) {
-          logger.DTK0029().throw()
+          throw logger.DTK0029().throw()
         }
 
         await import('open').then(r => r.default(resolved))