fix(api_call): Handle JsonException on success response path (#117)

* Handle JsonException on success response path

When a 2xx response contains invalid JSON and asJson is true,
json_decode with JSON_THROW_ON_ERROR throws an uncaught
JsonException. Wrap the call in a try/catch and re-throw as
TypesenseClientError with the HTTP status code and a truncated
response body for debugging.

Fixes #52

* test(api_call): test jsonexception on success response path

---------

Co-authored-by: Fanis Tharropoulos <ftharropoulos@gmail.com>

Author: eyupcanakman

src/ApiCall.php

@@ -270,7 +270,20 @@ private function makeRequest(string $method, string $endPoint, bool $asJson, arr
                         ->setMessage($errorMessage);
                 }
 
-                return $asJson ? json_decode($responseContents, true, 512, JSON_THROW_ON_ERROR) : $responseContents;
+                if (!$asJson) {
+                    return $responseContents;
+                }
+
+                try {
+                    return json_decode($responseContents, true, 512, JSON_THROW_ON_ERROR);
+                } catch (JsonException $exception) {
+                    throw new TypesenseClientError(
+                        'HTTP ' . $response->getStatusCode() . ' response is not valid JSON: '
+                        . substr($responseContents, 0, 200),
+                        0,
+                        $exception
+                    );
+                }
             } catch (HttpException $exception) {
                 $statusCode = $exception->getResponse()->getStatusCode();
 

tests/Feature/ApiCallRetryTest.php

@@ -9,10 +9,12 @@
 use Typesense\Exceptions\RequestMalformed;
 use Http\Client\Exception\HttpException;
 use Http\Client\Exception\TransferException;
+use JsonException;
 use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\StreamInterface;
 use Psr\Http\Message\RequestInterface;
+use Typesense\Exceptions\TypesenseClientError;
 
 class ApiCallRetryTest extends TestCase
 {
@@ -464,4 +466,38 @@ public function testDoesNotSleepOnFinalRetryAttempt(): void
             "Execution was too fast ({$actualDuration}s), suggesting sleep intervals were skipped"
         );
     }
-} 
+
+    public function testThrowsTypesenseClientErrorWhenSuccessResponseContainsInvalidJson(): void
+    {
+        $httpClient = $this->createMock(ClientInterface::class);
+        $httpClient->method('sendRequest')
+            ->willReturnCallback(function () {
+                $response = $this->createMock(ResponseInterface::class);
+                $response->method('getStatusCode')->willReturn(200);
+                $stream = $this->createMock(StreamInterface::class);
+                $stream->method('getContents')->willReturn('{invalid json');
+                $response->method('getBody')->willReturn($stream);
+                return $response;
+            });
+
+        $config = new Configuration([
+            'api_key' => 'test-key',
+            'nodes' => [
+                ['host' => 'node1', 'port' => 8108, 'protocol' => 'http']
+            ],
+            'num_retries' => 0,
+            'client' => $httpClient
+        ]);
+
+        $apiCall = new ApiCall($config);
+
+        try {
+            $apiCall->get('/test', []);
+            $this->fail('Expected TypesenseClientError to be thrown');
+        } catch (TypesenseClientError $exception) {
+            $this->assertStringContainsString('HTTP 200 response is not valid JSON:', $exception->getMessage());
+            $this->assertStringContainsString('{invalid json', $exception->getMessage());
+            $this->assertInstanceOf(JsonException::class, $exception->getPrevious());
+        }
+    }
+}