Fix Honeycomb detector with both key formats (#777)

MNThomson · web-flow · commit d7123c696535 · 2022-09-02T11:44:16.000-07:00
diff --git a/pkg/detectors/honeycomb/honeycomb.go b/pkg/detectors/honeycomb/honeycomb.go
@@ -20,7 +20,8 @@ var (
 	client = common.SaneHttpClient()
 
 	// Make sure that your group is surrounded in boundary characters such as below to reduce false positives.
-	keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"Honeycomb"}) + `\b([0-9a-zA-Z]{22})\b`)
+	// Older + Newer API key format. See pull#687 for discussion
+	keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"Honeycomb"}) + `\b([0-9a-f]{32}|[0-9a-zA-Z]{22})\b`)
 )
 
 // Keywords are used for efficiently pre-filtering chunks.

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,8 @@ var (`
`20`	`20`	`client = common.SaneHttpClient()`
`21`	`21`
`22`	`22`	`// Make sure that your group is surrounded in boundary characters such as below to reduce false positives.`
`23`		- keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"Honeycomb"}) + `\b([0-9a-zA-Z]{22})\b`)
	`23`	`+ // Older + Newer API key format. See pull#687 for discussion`
	`24`	+ keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"Honeycomb"}) + `\b([0-9a-f]{32}\|[0-9a-zA-Z]{22})\b`)
`24`	`25`	`)`
`25`	`26`
`26`	`27`	`// Keywords are used for efficiently pre-filtering chunks.`