refactor(config): use reference.conf as single source of defaults

Move all default values from scattered bean field initializers into
reference.conf, making it the single source of truth for config defaults.
Expose config beans as static singletons for convenient access.

- Add comprehensive reference.conf with defaults for all config domains
- Auto-bind discovery, PBFT, and list fields in NodeConfig
- Expose config beans as static singletons (NodeConfig.getInstance() etc.)
- Move postProcess logic into bean classes
- Fix test configs (external.ip=null -> empty string)
- Document manual-read keys with reasons in reference.conf

Author: vividctrlalt

common/src/main/java/org/tron/core/config/Configuration.java

@@ -48,7 +48,8 @@ public static com.typesafe.config.Config getByFileName(
 
   private static void resolveConfigFile(String fileName, File confFile) {
     if (confFile.exists()) {
-      config = ConfigFactory.parseFile(confFile);
+      config = ConfigFactory.parseFile(confFile)
+          .withFallback(ConfigFactory.defaultReference());
     } else if (Thread.currentThread().getContextClassLoader().getResourceAsStream(fileName)
         != null) {
       config = ConfigFactory.load(fileName);

common/src/main/java/org/tron/core/config/args/BlockConfig.java

@@ -7,7 +7,6 @@
 
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigBeanFactory;
-import com.typesafe.config.ConfigFactory;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
@@ -26,12 +25,7 @@ public class BlockConfig {
   private long proposalExpireTime = DEFAULT_PROPOSAL_EXPIRE_TIME;
   private int checkFrozenTime = 1;
 
-  private static final Config DEFAULTS = ConfigFactory.parseString(
-      "needSyncCheck = false\n"
-          + "maintenanceTimeInterval = 21600000\n"
-          + "proposalExpireTime = " + DEFAULT_PROPOSAL_EXPIRE_TIME + "\n"
-          + "checkFrozenTime = 1\n"
-  );
+  // Defaults come from reference.conf (loaded globally via Configuration.java)
 
   /**
    * Create BlockConfig from the "block" section of the application config.
@@ -44,9 +38,7 @@ public static BlockConfig fromConfig(Config config) {
           + "config.conf, please set the value in block.proposalExpireTime.", PARAMETER_INIT);
     }
 
-    Config blockSection = config.hasPath("block")
-        ? config.getConfig("block").withFallback(DEFAULTS)
-        : DEFAULTS;
+    Config blockSection = config.getConfig("block");
     BlockConfig blockConfig = ConfigBeanFactory.create(blockSection, BlockConfig.class);
     blockConfig.postProcess();
     return blockConfig;

common/src/main/java/org/tron/core/config/args/CommitteeConfig.java

@@ -2,7 +2,6 @@
 
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigBeanFactory;
-import com.typesafe.config.ConfigFactory;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
@@ -84,57 +83,7 @@ public class CommitteeConfig {
 
   // proposalExpireTime is NOT a committee field — it's in block.* and handled by BlockConfig
 
-  private static final Config DEFAULTS;
-
-  static {
-    StringBuilder sb = new StringBuilder();
-    sb.append("allowCreationOfContracts = 0\n");
-    sb.append("allowMultiSign = 0\n");
-    sb.append("allowAdaptiveEnergy = 0\n");
-    sb.append("allowDelegateResource = 0\n");
-    sb.append("allowSameTokenName = 0\n");
-    sb.append("allowTvmTransferTrc10 = 0\n");
-    sb.append("allowTvmConstantinople = 0\n");
-    sb.append("allowTvmSolidity059 = 0\n");
-    sb.append("forbidTransferToContract = 0\n");
-    sb.append("allowShieldedTRC20Transaction = 0\n");
-    sb.append("allowMarketTransaction = 0\n");
-    sb.append("allowTransactionFeePool = 0\n");
-    sb.append("allowBlackHoleOptimization = 0\n");
-    sb.append("allowNewResourceModel = 0\n");
-    sb.append("allowTvmIstanbul = 0\n");
-    sb.append("allowProtoFilterNum = 0\n");
-    sb.append("allowAccountStateRoot = 0\n");
-    sb.append("changedDelegation = 0\n");
-    sb.append("allowPBFT = 0\n");
-    sb.append("pBFTExpireNum = 20\n");
-    sb.append("allowTvmFreeze = 0\n");
-    sb.append("allowTvmVote = 0\n");
-    sb.append("allowTvmLondon = 0\n");
-    sb.append("allowTvmCompatibleEvm = 0\n");
-    sb.append("allowHigherLimitForMaxCpuTimeOfOneTx = 0\n");
-    sb.append("allowNewRewardAlgorithm = 0\n");
-    sb.append("allowOptimizedReturnValueOfChainId = 0\n");
-    sb.append("allowTvmShangHai = 0\n");
-    sb.append("allowOldRewardOpt = 0\n");
-    sb.append("allowEnergyAdjustment = 0\n");
-    sb.append("allowStrictMath = 0\n");
-    sb.append("consensusLogicOptimization = 0\n");
-    sb.append("allowTvmCancun = 0\n");
-    sb.append("allowTvmBlob = 0\n");
-    sb.append("unfreezeDelayDays = 0\n");
-    sb.append("allowReceiptsMerkleRoot = 0\n");
-    sb.append("allowAccountAssetOptimization = 0\n");
-    sb.append("allowAssetOptimization = 0\n");
-    sb.append("allowNewReward = 0\n");
-    sb.append("memoFee = 0\n");
-    sb.append("allowDelegateOptimization = 0\n");
-    sb.append("allowDynamicEnergy = 0\n");
-    sb.append("dynamicEnergyThreshold = 0\n");
-    sb.append("dynamicEnergyIncreaseFactor = 0\n");
-    sb.append("dynamicEnergyMaxFactor = 0\n");
-    DEFAULTS = ConfigFactory.parseString(sb.toString());
-  }
+  // Defaults come from reference.conf (loaded globally via Configuration.java)
 
   /**
    * Create CommitteeConfig from the "committee" section of the application config.
@@ -144,9 +93,7 @@ public class CommitteeConfig {
    * are excluded from automatic binding and handled manually after.
    */
   public static CommitteeConfig fromConfig(Config config) {
-    Config section = config.hasPath("committee")
-        ? config.getConfig("committee").withFallback(DEFAULTS)
-        : DEFAULTS;
+    Config section = config.getConfig("committee");
 
     // ConfigBeanFactory derives key names from setter methods. For setPBFTExpireNum()
     // it expects "PBFTExpireNum" (capital P), but config.conf uses "pBFTExpireNum".

common/src/main/java/org/tron/core/config/args/EventConfig.java

@@ -68,21 +68,7 @@ public static class FilterConfig {
     private List<String> contractTopic = new ArrayList<>();
   }
 
-  private static final Config DEFAULTS = ConfigFactory.parseString(
-      "enable = false\n"
-          + "version = 0\n"
-          + "startSyncBlockNum = 0\n"
-          + "path = \"\"\n"
-          + "server = \"\"\n"
-          + "dbconfig = \"\"\n"
-          + "contractParse = true\n"
-          + "native { useNativeQueue = true, bindport = 5555, sendqueuelength = 1000 }\n"
-          + "topics = []\n"
-          + "topicDefaults { triggerName = \"\", enable = false, topic = \"\","
-          + " solidified = false, ethCompatible = false, redundancy = false }\n"
-          + "filter { fromblock = \"\", toblock = \"\","
-          + " contractAddress = [\"\"], contractTopic = [\"\"] }\n"
-  );
+  // Defaults come from reference.conf (loaded globally via Configuration.java)
 
   /**
    * Create EventConfig from the "event.subscribe" section of the application config.
@@ -91,9 +77,7 @@ public static class FilterConfig {
    * "nativeQueue" but config key is "native". We handle this manually after binding.
    */
   public static EventConfig fromConfig(Config config) {
-    Config section = config.hasPath("event.subscribe")
-        ? config.getConfig("event.subscribe").withFallback(DEFAULTS)
-        : DEFAULTS;
+    Config section = config.getConfig("event.subscribe");
 
     // "native" is a Java reserved word, "topics" has optional fields per item —
     // strip both before binding, read manually

common/src/main/java/org/tron/core/config/args/GenesisConfig.java

@@ -2,7 +2,6 @@
 
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigBeanFactory;
-import com.typesafe.config.ConfigFactory;
 import java.util.ArrayList;
 import java.util.List;
 import lombok.Getter;
@@ -42,18 +41,10 @@ public static class WitnessConfig {
     private long voteCount = 0;
   }
 
-  private static final Config DEFAULTS = ConfigFactory.parseString(
-      "timestamp = \"\"\n"
-          + "parentHash = \"\"\n"
-          + "assets = []\n"
-          + "witnesses = []\n"
-  );
+  // Defaults come from reference.conf (loaded globally via Configuration.java)
 
   public static GenesisConfig fromConfig(Config config) {
-    if (!config.hasPath("genesis.block")) {
-      return new GenesisConfig();
-    }
-    Config section = config.getConfig("genesis.block").withFallback(DEFAULTS);
+    Config section = config.getConfig("genesis.block");
     return ConfigBeanFactory.create(section, GenesisConfig.class);
   }
 }

common/src/main/java/org/tron/core/config/args/MetricsConfig.java

@@ -2,7 +2,6 @@
 
 import com.typesafe.config.Config;
 import com.typesafe.config.ConfigBeanFactory;
-import com.typesafe.config.ConfigFactory;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.extern.slf4j.Slf4j;
@@ -36,20 +35,13 @@ public static class InfluxDbConfig {
     private int metricsReportInterval = 10;
   }
 
-  private static final Config DEFAULTS = ConfigFactory.parseString(
-      "storageEnable = false\n"
-          + "prometheus { enable = false, port = 9527 }\n"
-          + "influxdb { ip = \"\", port = 8086, database = metrics,"
-          + " metricsReportInterval = 10 }\n"
-  );
+  // Defaults come from reference.conf (loaded globally via Configuration.java)
 
   /**
    * Create MetricsConfig from the "node.metrics" section of the application config.
    */
   public static MetricsConfig fromConfig(Config config) {
-    Config section = config.hasPath("node.metrics")
-        ? config.getConfig("node.metrics").withFallback(DEFAULTS)
-        : DEFAULTS;
+    Config section = config.getConfig("node.metrics");
     return ConfigBeanFactory.create(section, MetricsConfig.class);
   }
 }