chore: fix ci

Author: tanvirtin

.luacheckrc

@@ -11,6 +11,7 @@ ignore = {
     "122", -- Indirectly setting a readonly global
     "431", -- Shadowing upvalue (acceptable in local scopes)
     "512", -- Loop is executed at most once (intentional in utils.object.first)
+    "631", -- Line too long (stylua handles line length)
 }
 
 globals = {
@@ -26,8 +27,12 @@ exclude_files = {
     "lua/vgit/vendor/*",
 }
 
-files["tests/"] = {
-    ignore = { "143" },
+local test_settings = {
+    ignore = {
+        "143", -- accessing undefined field of global (assert.are.same, assert.is_true, etc.)
+        "211", -- unused variable (common in tests: local eq = ..., local _, err = ...)
+        "231", -- variable never accessed in for loop (common in destructured returns)
+    },
     read_globals = {
         "describe",
         "it",
@@ -39,3 +44,6 @@ files["tests/"] = {
         "mock",
     },
 }
+
+files["tests/"] = test_settings
+files["lua/**/*_spec.lua"] = test_settings

.styluaignore

@@ -0,0 +1,2 @@
+lua/vgit/features/screens/ProjectDiffView.lua
+lua/vgit/git/git_status.lua

lua/vgit/cli/commands/branch_spec.lua

@@ -3,14 +3,24 @@ local eq = assert.are.same
 -- Mock the event module to avoid async issues in tests
 local mock_event = {
   await = function() end,
-  async = function(fn) return fn end,
-  debounce = function(fn) return fn, function() end end,
-  debounce_async = function(fn) return fn, function() end end,
+  async = function(fn)
+    return fn
+  end,
+  debounce = function(fn)
+    return fn, function() end
+  end,
+  debounce_async = function(fn)
+    return fn, function() end
+  end,
   on = function() end,
   emit = function() end,
-  custom_on = function() return function() end end,
+  custom_on = function()
+    return function() end
+  end,
   buffer_on = function() end,
-  promisify = function(fn) return fn end,
+  promisify = function(fn)
+    return fn
+  end,
   group = 'VGitGroup',
   register_module = function() end,
 }
@@ -51,14 +61,16 @@ describe('branch_command:', function()
                   { name = 'feature', hash = 'def456' },
                   { name = 'main', hash = 'abc123' },
                   { name = 'develop', hash = 'ghi789' },
-                }, nil
+                },
+                  nil
               end,
               current_branch = function()
                 return 'main', nil
               end,
             }
           end,
-        }, nil
+        },
+          nil
       end,
     }
 
@@ -105,7 +117,9 @@ describe('branch_command:', function()
 
     save_package('vgit.core.console')
     package.loaded['vgit.core.console'] = {
-      error = function(msg) error_msg = msg end,
+      error = function(msg)
+        error_msg = msg
+      end,
       info = function() end,
     }
 
@@ -133,7 +147,8 @@ describe('branch_command:', function()
               end,
             }
           end,
-        }, nil
+        },
+          nil
       end,
     }
 
@@ -145,7 +160,9 @@ describe('branch_command:', function()
     save_package('vgit.core.console')
     package.loaded['vgit.core.console'] = {
       error = function() end,
-      info = function(msg) info_msg = msg end,
+      info = function(msg)
+        info_msg = msg
+      end,
     }
 
     package.loaded['vgit.cli.commands.branch'] = nil
@@ -172,7 +189,8 @@ describe('branch_command:', function()
               end,
             }
           end,
-        }, nil
+        },
+          nil
       end,
     }
 
@@ -183,7 +201,9 @@ describe('branch_command:', function()
 
     save_package('vgit.core.console')
     package.loaded['vgit.core.console'] = {
-      error = function(msg) error_msg = msg end,
+      error = function(msg)
+        error_msg = msg
+      end,
       info = function() end,
     }
 

lua/vgit/cli/commands/diff.lua

@@ -14,9 +14,7 @@ local diff_command = {}
 
 local function format_ref_for_display(ref)
   -- Only truncate if it looks like a full commit hash (40 hex chars)
-  if ref:match('^[a-f0-9]+$') and #ref == 40 then
-    return ref:sub(1, 7)
-  end
+  if ref:match('^[a-f0-9]+$') and #ref == 40 then return ref:sub(1, 7) end
   return ref
 end
 
@@ -153,9 +151,9 @@ diff_command.execute = event.async(function(args)
     opts.ambiguous = nil
   end
 
-  local base_ref, compare_ref, is_range, ref_err
+  local base_ref, compare_ref, _, ref_err
   if #opts.refs > 0 then
-    base_ref, compare_ref, is_range, ref_err = normalize_refs(opts.refs)
+    base_ref, compare_ref, _, ref_err = normalize_refs(opts.refs)
     if ref_err then
       console.error(ref_err)
       return
@@ -231,9 +229,7 @@ diff_command.execute = event.async(function(args)
         to = 'index'
         -- Look up old_filename from git status for renames
         local file_status = git_status.ls(repo:get_path(), filename)
-        if file_status and file_status.old_filename then
-          old_filename = file_status.old_filename
-        end
+        if file_status and file_status.old_filename then old_filename = file_status.old_filename end
       else
         -- Unstaged changes: index vs disk (working tree changes)
         from = 'index'
@@ -321,9 +317,7 @@ diff_command.execute = event.async(function(args)
 
     local entries = {}
     for i = 1, #funcs do
-      if results[i] then
-        table.insert(entries, results[i])
-      end
+      if results[i] then table.insert(entries, results[i]) end
     end
 
     if #entries == 0 then

lua/vgit/cli/commands/show.lua

@@ -19,16 +19,12 @@ function show_command.parse_args(args)
       table.insert(opts.flags, arg)
     else
       -- First non-flag arg is the commit
-      if not opts.commit then
-        opts.commit = arg
-      end
+      if not opts.commit then opts.commit = arg end
     end
   end
 
   -- Default to HEAD if no commit specified
-  if not opts.commit then
-    opts.commit = 'HEAD'
-  end
+  if not opts.commit then opts.commit = 'HEAD' end
 
   return opts
 end
@@ -115,9 +111,7 @@ show_command.execute = event.async(function(args)
 
   local entries = {}
   for i = 1, #funcs do
-    if results[i] then
-      table.insert(entries, results[i])
-    end
+    if results[i] then table.insert(entries, results[i]) end
   end
 
   if #entries == 0 then

lua/vgit/cli/commands/status.lua

@@ -39,9 +39,7 @@ status_command.execute = event.async(function()
   local cursor_lnum = Window(0):get_lnum()
 
   local current_filename = nil
-  if buf_name and buf_name ~= '' then
-    current_filename = fs.make_relative(repo:get_path(), buf_name)
-  end
+  if buf_name and buf_name ~= '' then current_filename = fs.make_relative(repo:get_path(), buf_name) end
 
   local transformed_data = {
     type = 'status',

lua/vgit/core/Config.lua

@@ -14,17 +14,13 @@ end
 function Config:get(key)
   assert(type(key) == 'string', 'type error :: expected string')
   local value = self.data[key]
-  if value == nil then
-    error(string.format('key "%s" does not exist', tostring(key)))
-  end
+  if value == nil then error(string.format('key "%s" does not exist', tostring(key))) end
 
   return value
 end
 
 function Config:set(key, value)
-  if self.data[key] == nil then
-    error(string.format('key "%s" does not exist', tostring(key)))
-  end
+  if self.data[key] == nil then error(string.format('key "%s" does not exist', tostring(key))) end
   if type(self.data[key]) ~= type(value) then
     error(string.format('type error :: expected %s', type(self.data[key])))
   end

lua/vgit/core/assertion.lua

@@ -1,8 +1,8 @@
 local assertion = {}
 
 function assertion.assert(cond, msg)
-  if not cond then error(debug.traceback(msg)) end
   if type(cond) == 'function' then cond = cond() end
+  if not cond then error(debug.traceback(msg)) end
 
   return assertion
 end