left-join-correction

Summary:

- Correction of `left join` from defective `inner join` implementation to proper `left outer join` implementation.

Author: general-kroll-4-life

internal/stackql/router/table_routing.go

@@ -537,11 +537,11 @@ func (v *standardTableRouteAstVisitor) Visit(node sqlparser.SQLNode) error {
 		//       and also so that
 		//       these are omitted from the WHERE clause.
 		switch node.Join {
-		case sqlparser.LeftJoinStr:
 		case sqlparser.RightJoinStr:
 		case sqlparser.StraightJoinStr:
 		case sqlparser.JoinStr:
-		case sqlparser.LeftOuterJoinStr:
+		case sqlparser.LeftJoinStr, sqlparser.LeftOuterJoinStr:
+			// LEFT JOIN and LEFT OUTER JOIN are semantically identical in SQL.
 			rhs := v.tables[node.RightExpr]
 			if rhs == nil {
 				return fmt.Errorf("table routing: nil RHS table in left outer join")

test/robot/functional/stackql_mocked_from_cmd_line.robot

@@ -1389,7 +1389,7 @@ Create and Interrogate Materialized View With Userspace Table Join and Aliasing
 
 Subquery Left Joined With Aliasing and Name Collision
     ${inputStr} =    Catenate
-    ...    select u1.UserName, u.UserId, u.Arn, u1.region from ( select Arn, UserName, UserId from aws.iam.users where region = 'us-east-1' ) u inner join aws.iam.users u1 on u1.Arn = u.Arn where region = 'us-east-1'  order by u1.UserName desc;
+    ...    select u1.UserName, u.UserId, u.Arn, u1.region from ( select Arn, UserName, UserId from aws.iam.users where region = 'us-east-1' ) u left join aws.iam.users u1 on u1.Arn = u.Arn where region = 'us-east-1'  order by u1.UserName desc;
     ${outputStr} =    Catenate    SEPARATOR=\n
     ...    |----------|-----------------------|--------------------------------------------------------------------------------|-----------|
     ...    |${SPACE}UserName${SPACE}|${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}UserId${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}|${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}Arn${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}${SPACE}|${SPACE}${SPACE}region${SPACE}${SPACE}${SPACE}|
@@ -2535,7 +2535,7 @@ Left Outer Join Network Infra Scalar in ON Condition
     ...    ${outputStr}
     ...    stdout=${CURDIR}/tmp/Left-Outer-Join-Network-Infra-Scalar-in-ON-Condition.tmp
 
-Left Inner Join Users
+Inner Join Users Cross Cloud Fuzzy Match
     ${sqliteInputStr} =    Catenate
     ...    select 
     ...    aid.UserName as aws_user_name
@@ -2591,7 +2591,7 @@ Left Inner Join Users
     ...    ${SQL_BACKEND_CFG_STR_CANONICAL}
     ...    ${inputStr}
     ...    ${outputStr}
-    ...    stdout=${CURDIR}/tmp/Left-Inner-Join-Users.tmp
+    ...    stdout=${CURDIR}/tmp/Inner-Join-Users-Cross-Cloud-Fuzzy-Match.tmp
 
 Google Admin Directory Small Response Also De Facto Credentials Path Env Var
     Set Environment Variable    GOOGLE_APPLICATION_CREDENTIALS    ${GOOGLE_APPLICATION_CREDENTIALS}