fix: drop node <=18 require's

Author: harlan-zw

src/cli.ts

@@ -3,7 +3,6 @@ import type { AgentType, OptimizeModel } from './agent'
 import type { PackageUsage } from './agent/detect-imports'
 import type { ProjectState } from './core'
 import { existsSync, readFileSync, realpathSync } from 'node:fs'
-import { createRequire } from 'node:module'
 import * as p from '@clack/prompts'
 import { defineCommand, runMain } from 'citty'
 import pLimit from 'p-limit'
@@ -14,16 +13,15 @@ import { getProjectState, hasConfig, isOutdated, readConfig, updateConfig } from
 import { timedSpinner } from './core/formatting'
 import { fetchLatestVersion, fetchNpmRegistryMeta } from './sources'
 
+import { version } from './version'
+
 // Suppress node:sqlite ExperimentalWarning (loaded lazily by retriv)
 const _emit = process.emit
 process.emit = (event: string, ...args: any[]) =>
   event === 'warning' && args[0]?.name === 'ExperimentalWarning' && args[0]?.message?.includes('SQLite')
     ? false
     : _emit.apply(process, [event, ...args])
 
-const require = createRequire(import.meta.url)
-const { version } = require('../package.json')
-
 // ── Helpers ──
 
 function getRepoHint(name: string, cwd: string): string | undefined {

src/commands/install.ts

@@ -11,7 +11,8 @@
 
 import type { AgentType, CustomPrompt, SkillSection } from '../agent'
 import type { SkillInfo } from '../core/lockfile'
-import { existsSync, lstatSync, mkdirSync, readdirSync, readFileSync, symlinkSync, unlinkSync, writeFileSync } from 'node:fs'
+import { copyFileSync, existsSync, lstatSync, mkdirSync, readdirSync, readFileSync, symlinkSync, unlinkSync, writeFileSync } from 'node:fs'
+import { homedir } from 'node:os'
 import * as p from '@clack/prompts'
 import { join } from 'pathe'
 import { agents, getModelLabel, optimizeDocs } from '../agent'
@@ -57,8 +58,7 @@ export async function installCommand(opts: InstallOptions): Promise<void> {
   const cwd = process.cwd()
   const agent = agents[opts.agent]
   const skillsDir = opts.global
-    // eslint-disable-next-line ts/no-require-imports
-    ? join(require('node:os').homedir(), '.skilld', 'skills')
+    ? join(homedir(), '.skilld', 'skills')
     : join(cwd, agent.skillsDir)
 
   // Collect lockfiles from all agent skill dirs and merge
@@ -186,8 +186,10 @@ export async function installCommand(opts: InstallOptions): Promise<void> {
         unlinkSync(sectionsLink)
       if (existsSync(cachedSections))
         symlinkSync(cachedSections, sectionsLink, 'junction')
-      if (regenerateBaseSkillMd(skillDir, pkgName, version, cwd, allSkillNames, info.source, info.packages))
-        regenerated.push({ name, pkgName, version, skillDir, packages: info.packages })
+      if (!copyFromExistingAgent(skillDir, name, allSkillsDirs)) {
+        if (regenerateBaseSkillMd(skillDir, pkgName, version, cwd, allSkillNames, info.source, info.packages))
+          regenerated.push({ name, pkgName, version, skillDir, packages: info.packages })
+      }
       spin.stop(`Linked ${name}`)
       continue
     }
@@ -316,8 +318,10 @@ export async function installCommand(opts: InstallOptions): Promise<void> {
         })), { dbPath: getPackageDbPath(pkgName, version) })
       }
 
-      if (regenerateBaseSkillMd(skillDir, pkgName, version, cwd, allSkillNames, info.source, info.packages))
-        regenerated.push({ name, pkgName, version, skillDir, packages: info.packages })
+      if (!copyFromExistingAgent(skillDir, name, allSkillsDirs)) {
+        if (regenerateBaseSkillMd(skillDir, pkgName, version, cwd, allSkillNames, info.source, info.packages))
+          regenerated.push({ name, pkgName, version, skillDir, packages: info.packages })
+      }
       spin.stop(`Downloaded and linked ${name}`)
     }
     else {
@@ -348,6 +352,24 @@ export async function installCommand(opts: InstallOptions): Promise<void> {
   p.outro('Install complete')
 }
 
+/** Copy SKILL.md from another agent's skill dir if one exists */
+function copyFromExistingAgent(skillDir: string, name: string, allSkillsDirs: string[]): boolean {
+  const targetMd = join(skillDir, 'SKILL.md')
+  if (existsSync(targetMd))
+    return false
+  for (const dir of allSkillsDirs) {
+    if (dir === skillDir)
+      continue
+    const candidateMd = join(dir, name, 'SKILL.md')
+    if (existsSync(candidateMd) && !lstatSync(candidateMd).isSymbolicLink()) {
+      mkdirSync(skillDir, { recursive: true })
+      copyFileSync(candidateMd, targetMd)
+      return true
+    }
+  }
+  return false
+}
+
 /** Try to recover original package name from sanitized name + source */
 function unsanitizeName(sanitized: string, source?: string): string {
   if (source?.includes('ungh://')) {

src/commands/status.ts

@@ -1,7 +1,6 @@
 import type { AgentType } from '../agent'
 import type { SkillInfo } from '../core/lockfile'
 import { existsSync, readdirSync, statSync } from 'node:fs'
-import { createRequire } from 'node:module'
 import * as p from '@clack/prompts'
 import { join } from 'pathe'
 import { agents, getAgentVersion } from '../agent'
@@ -12,9 +11,7 @@ import { formatSource, timeAgo } from '../core/formatting'
 import { parsePackages } from '../core/lockfile'
 
 import { iterateSkills } from '../core/skills'
-
-const require = createRequire(import.meta.url)
-const { version: skilldVersion } = require('../package.json')
+import { version as skilldVersion } from '../version'
 
 export interface StatusOptions {
   global?: boolean

src/version.ts

@@ -0,0 +1,4 @@
+import { createRequire } from 'node:module'
+
+const require = createRequire(import.meta.url)
+export const version = require('../package.json').version

test/unit/cache-storage.test.ts

@@ -74,42 +74,6 @@ describe('cache/storage', () => {
     })
   })
 
-  describe('linkReferences', () => {
-    it('removes existing link before creating new one', async () => {
-      const { existsSync, lstatSync, unlinkSync, symlinkSync } = await import('node:fs')
-      const { linkReferences } = await import('../../src/cache/storage')
-      // cachedDocsPath exists
-      vi.mocked(existsSync).mockReturnValue(true)
-      // lstatSync returns a symlink stat for existing link
-      vi.mocked(lstatSync).mockReturnValue({ isSymbolicLink: () => true, isFile: () => false } as any)
-
-      linkReferences('/project/.claude/skills/vue', 'vue', '3.4.0')
-
-      expect(unlinkSync).toHaveBeenCalled()
-      expect(symlinkSync).toHaveBeenCalledWith(
-        expect.stringContaining('vue@3.4'),
-        expect.stringContaining('.skilld/docs'),
-        'junction',
-      )
-    })
-
-    it('skips unlink if no existing link', async () => {
-      const { existsSync, lstatSync, unlinkSync, symlinkSync } = await import('node:fs')
-      const { linkReferences } = await import('../../src/cache/storage')
-      // cachedDocsPath exists
-      vi.mocked(existsSync).mockReturnValue(true)
-      // lstatSync throws ENOENT (no existing link)
-      vi.mocked(lstatSync).mockImplementation(() => {
-        throw new Error('ENOENT')
-      })
-
-      linkReferences('/project/.claude/skills/vue', 'vue', '3.4.0')
-
-      expect(unlinkSync).not.toHaveBeenCalled()
-      expect(symlinkSync).toHaveBeenCalled()
-    })
-  })
-
   describe('listCached', () => {
     it('returns empty array when references dir missing', async () => {
       const { existsSync } = await import('node:fs')

test/unit/cache.test.ts

@@ -124,36 +124,4 @@ describe('cache', () => {
       expect(writeFileSync).toHaveBeenCalledTimes(2)
     })
   })
-
-  describe('linkReferences', () => {
-    beforeEach(() => {
-      vi.resetAllMocks()
-    })
-
-    it('removes existing link before creating new one', async () => {
-      const { existsSync, lstatSync, unlinkSync, symlinkSync } = await import('node:fs')
-      const { linkReferences } = await import('../../src/cache')
-      vi.mocked(existsSync).mockReturnValue(true)
-      vi.mocked(lstatSync).mockReturnValue({ isSymbolicLink: () => true, isFile: () => false } as any)
-
-      linkReferences('/project/.claude/skills/vue', 'vue', '3.4.0')
-
-      expect(unlinkSync).toHaveBeenCalled()
-      expect(symlinkSync).toHaveBeenCalled()
-    })
-
-    it('creates symlink without unlinking if no existing link', async () => {
-      const { existsSync, lstatSync, unlinkSync, symlinkSync } = await import('node:fs')
-      const { linkReferences } = await import('../../src/cache')
-      vi.mocked(existsSync).mockReturnValue(true)
-      vi.mocked(lstatSync).mockImplementation(() => {
-        throw new Error('ENOENT')
-      })
-
-      linkReferences('/project/.claude/skills/vue', 'vue', '3.4.0')
-
-      expect(unlinkSync).not.toHaveBeenCalled()
-      expect(symlinkSync).toHaveBeenCalled()
-    })
-  })
 })