Resolve Checks are using Current HEAP instead of Max HEAP and BUG in check agnostic JAVA Version (#28)

* Change MAX HEAP instead Current HEAP and fix bug java agnostic

* Add MAX HEAP metric and fix bug java agnostic

* Allow select limit to current or MAX HEAP

Author: juan-moreno

bin/check-java-heap-pcnt-java8.sh

@@ -6,36 +6,50 @@
 # Date: 2017-02-10
 # Modified: Nikoletta Kyriakidou
 
+# Date: 2018-08-30
+# Modified: Juan Moreno Martinez - Change MAX HEAP instead Current HEAP
+
 # You must have openjdk-8-jdk and openjdk-8-jre packages installed
 # http://openjdk.java.net/install/
 #
 # Also make sure the user "sensu" can sudo without password
 
 # #RED
-while getopts 'w:c:n:o:j:hp' OPT; do
+while getopts 'w:c:n:o:j:l:hp' OPT; do
   case $OPT in
     w)  WARN=$OPTARG;;
     c)  CRIT=$OPTARG;;
     n)  NAME=$OPTARG;;
     o)  OPTIONS=$OPTARG;;
     j)  JAVA_BIN=$OPTARG;;
+    l)  HEAP_MAX=$OPTARG;;
     h)  hlp="yes";;
     p)  perform="yes";;
     *)  unknown="yes";;
   esac
 done
 
+
 # usage
 HELP="
-    usage: $0 [ -n value -w value -c value -o value -p -h ]
-
+    usage: $0 [ -n value -w value -c value -o value -l value -p -h ]
         -n --> Name of JVM process < value
         -w --> Warning Percentage < value
         -c --> Critical Percentage < value
         -o --> options to pass to jps
         -j --> path to java bin dir (include trailing /)
         -p --> print out performance data
         -h --> print this help screen
+        -l --> limit, valid value max or current (default current)
+               current: when -Xms and -Xmx same value
+               max: when -Xms and -Xmx have different values
+
+Requirement: User that launch script must be permisions in sudoers for jps,jstat,jmap
+sudoers lines suggested:
+----------
+sensu ALL=(ALL) NOPASSWD: /usr/bin/jps, /usr/bin/jstat, /usr/bin/jmap
+Defaults:sensu !requiretty
+----------
 "
 
 if [ "$hlp" = "yes" ]; then
@@ -57,8 +71,15 @@ projectSize=$(printf "%s\n" $(printf "$PIDS" | wc -w))
 i=0
 for PID in $PIDS
 do
-	#Get heap capacity of JVM
-	TotalHeap=$(sudo ${JAVA_BIN}jstat -gccapacity $PID  | tail -n 1 | awk '{ print ($4 + $5 + $6 + $10) / 1024 }')
+  #Get heap capacity of JVM
+  if [ "$HEAP_MAX" == "" ] || [ "$HEAP_MAX" == "current" ]; then
+    TotalHeap=$(sudo ${JAVA_BIN}jstat -gccapacity $PID  | tail -n 1 | awk '{ print ($4 + $5 + $6 + $10) / 1024 }')
+  elif [[ "$HEAP_MAX" == "max" ]]; then
+    TotalHeap=$(sudo ${JAVA_BIN}jmap -heap $PID 2> /dev/null | grep MaxHeapSize | tr -s " " | tail -n1 | awk '{ print $3 /1024 /1024 }')
+  else
+    echo "limit options must be max or current"
+    exit 1
+  fi
 
 	#Determine amount of used heap JVM is using
 	UsedHeap=$(sudo ${JAVA_BIN}jstat -gc $PID  | tail -n 1 | awk '{ print ($3 + $4 + $6 + $8) / 1024 }')

bin/check-java-heap-pcnt.sh

@@ -9,19 +9,23 @@
 # Date: 2017-06-06
 # Modified: Nic Scott - re-work to be java version agnostic
 
+# Date: 2018-08-30
+# Modified: Juan Moreno Martinez - Change MAX HEAP instead Current HEAP and fix bug java agnostic
+
 # depends on jps and jstat in openjdk-devel in openjdk-<VERSION>-jdk and
 # openjdk-<VERSION>-jre packages being installed
 # http://openjdk.java.net/install/
 
 # Also make sure the user "sensu" can sudo jps and jstat without password
 
-while getopts 'w:c:n:o:j:hp' OPT; do
+while getopts 'w:c:n:o:j:l:hp' OPT; do
   case $OPT in
     w)  WARN=$OPTARG;;
     c)  CRIT=$OPTARG;;
     n)  NAME=$OPTARG;;
     o)  OPTIONS=$OPTARG;;
     j)  JAVA_BIN=$OPTARG;;
+    l)  HEAP_MAX=$OPTARG;;
     h)  hlp="yes";;
     p)  perform="yes";;
     *)  unknown="yes";;
@@ -30,14 +34,24 @@ done
 
 # usage
 HELP="
-usage: $0 [ -n value -w value -c value -o value -p -h ]
+usage: $0 [ -n value -w value -c value -o value -l value -p -h ]
   -n --> Name of JVM process < value
   -w --> Warning Percentage < value
   -c --> Critical Percentage < value
   -o --> options to pass to jps
   -j --> path to java bin dir (include trailing /)
   -p --> print out performance data
   -h --> print this help screen
+  -l --> limit, valid value max or current (default current)
+         current: when -Xms and -Xmx same value
+         max: when -Xms and -Xmx have different values
+
+Requirement: User that launch script must be permisions in sudoers for jps,jstat,jmap
+sudoers lines suggested:
+----------
+sensu ALL=(ALL) NOPASSWD: /usr/bin/jps, /usr/bin/jstat, /usr/bin/jmap
+Defaults:sensu !requiretty
+----------
 "
 
 if [ "$hlp" = "yes" ]; then
@@ -62,7 +76,7 @@ fi
 JSTAT=$(sudo ${JAVA_BIN}jstat -gc $PID  | tail -n 1)
 
 # Java 8 jstat -gc returns 17 columns Java 7 returns 15
-if [[ ${#JSTAT[@]} -gt 15 ]]; then
+if [[ $(echo $JSTAT| wc -w) -gt 15 ]]; then
   # Metaspace is not a part of heap in Java 8
   #Get heap capacity of JVM
   TotalHeap=$(echo $JSTAT | awk '{ print ($1 + $2 + $5 + $7) / 1024 }')
@@ -76,6 +90,14 @@ else
   UsedHeap=$(echo $JSTAT | awk '{ print ($3 + $4 + $6 + $8 + $10) / 1024 }')
 fi
 
+
+if [[ "$HEAP_MAX" == "max" ]]; then
+  TotalHeap=$(sudo ${JAVA_BIN}jmap -heap $PID 2> /dev/null | grep MaxHeapSize | tr -s " " | tail -n1 | awk '{ print $3 /1024 /1024 }')
+elif [ "$HEAP_MAX" != "" ] && [ "$HEAP_MAX" != "current" ]; then
+  echo "limit options must be max or current"
+  exit 3
+fi
+
 #Get heap usage percentage
 HeapPer=$(echo "scale=3; $UsedHeap / $TotalHeap * 100" | bc -l| cut -d "." -f1)
 

bin/java-heap-pcnt.sh

@@ -6,17 +6,21 @@
 # Date: 2013-9-30
 # Modified: Mario Harvey - badmadrad.com
 
+# Date: 2018-08-30
+# Modified: Juan Moreno Martinez - Change MAX HEAP instead Current HEAP
+
 # You must have openjdk-7-jdk and openjdk-7-jre packages installed
 # http://openjdk.java.net/install/
 
 # Also make sure the user "sensu" can sudo without password
 
 # #RED
-while getopts 'w:c:n:hp' OPT; do
+while getopts 'w:c:n:l:hp' OPT; do
   case $OPT in
     w)  WARN=$OPTARG;;
     c)  CRIT=$OPTARG;;
     n)  NAME=$OPTARG;;
+    l)  HEAP_MAX=$OPTARG;;
     h)  hlp="yes";;
     p)  perform="yes";;
     *)  unknown="yes";;
@@ -32,6 +36,16 @@ HELP="
         -c --> Critical Percentage < value
         -p --> print out performance data
         -h --> print this help screen
+        -l --> limit, valid value max or current (default current)
+               current: when -Xms and -Xmx same value
+               max: when -Xms and -Xmx have different values
+
+Requirement: User that launch script must be permisions in sudoers for jps,jstat,jmap
+sudoers lines suggested:
+----------
+sensu ALL=(ALL) NOPASSWD: /usr/bin/jps, /usr/bin/jstat, /usr/bin/jmap
+Defaults:sensu !requiretty
+----------
 "
 
 if [ "$hlp" = "yes" ]; then
@@ -53,8 +67,14 @@ if [ $COUNT != 1 ]; then
 fi
 
 #Get heap capacity of JVM
-TotalHeap=$(sudo jstat -gccapacity $PID  | tail -n 1 | awk '{ print ($4 + $5 + $6 + $10) / 1024 }')
-
+if [ "$HEAP_MAX" == "" ] || [ "$HEAP_MAX" == "current" ]; then
+  TotalHeap=$(sudo ${JAVA_BIN}jstat -gccapacity $PID  | tail -n 1 | awk '{ print ($4 + $5 + $6 + $10) / 1024 }')
+elif [[ "$HEAP_MAX" == "max" ]]; then
+  TotalHeap=$(sudo ${JAVA_BIN}jmap -heap $PID 2> /dev/null | grep MaxHeapSize | tr -s " " | tail -n1 | awk '{ print $3 /1024 /1024 }')
+else
+  echo "limit options must be max or current"
+  exit 1
+fi
 #Determine amount of used heap JVM is using
 UsedHeap=$(sudo jstat -gc $PID  | tail -n 1 | awk '{ print ($3 + $4 + $6 + $8 + $10) / 1024 }')
 

bin/metrics-java-heap-graphite-java8.sh

@@ -4,6 +4,9 @@
 
 # Modified: Nikoletta Kyriakidou
 
+# Date: 2018-08-30
+# Modified: Juan Moreno Martinez - Add MAX HEAP metric
+
 # You must have openjdk-8-jdk and openjdk-8-jre packages installed
 # http://openjdk.java.net/install/
 
@@ -37,6 +40,9 @@ NAME=${NAME:=0}
 PID=$(sudo jps | grep " $NAME$" | awk '{ print $1}')
 for PID in $PIDS
 do
+  #Get max heap capacity of JVM
+  MaxHeap=$(sudo jmap -heap $PID 2> /dev/null | grep MaxHeapSize | tr -s " " | tail -n1 | awk '{ print $3 /1024 /1024 }')
+
   #Get heap capacity of JVM
   TotalHeap=$(sudo jstat -gccapacity $PID  | tail -n 1 | awk '{ print ($4 + $5 + $6 + $10) / 1024 }')
 
@@ -60,6 +66,7 @@ do
 		project=$projectName
 	fi
 
+  echo "JVMs.$SCHEME.$project.Max_Heap $MaxHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Committed_Heap $TotalHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Used_Heap $UsedHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Eden_Util $ParEden `date '+%s'`"

bin/metrics-java-heap-graphite.sh

@@ -7,6 +7,9 @@
 # Date: 2017-06-06
 # Modified: Nic Scott - re-work to be java version agnostic
 
+# Date: 2018-08-30
+# Modified: Juan Moreno Martinez - Add MAX HEAP metric and fix bug java agnostic
+
 # depends on jps and jstat in openjdk-devel in openjdk-<VERSION>-jdk and
 # openjdk-<VERSION>-jre packages being installed
 # http://openjdk.java.net/install/
@@ -49,6 +52,9 @@ do
   JSTAT=$(sudo ${JAVA_BIN}jstat -gc $PID  | tail -n 1)
 
   # Java version indifferent memory stats
+  #Determine MaxHeap
+  MaxHeap=$(sudo jmap -heap $PID 2> /dev/null | grep MaxHeapSize | tr -s " " | tail -n1 | awk '{ print $3 /1024 /1024 }')
+
   #Determine Old Space Utilization
   OldGen=$(echo $JSTAT | awk '{ print ($8) / 1024 }')
 
@@ -60,7 +66,7 @@ do
 
   # Java version-specific memory stats
   # Java 8 jstat -gc returns 17 columns Java 7 returns 15
-  if [[ ${#JSTAT[@]} -gt 15 ]]; then
+  if [[ $(echo $JSTAT| wc -w) -gt 15 ]]; then
     # Metaspace is NOT a part of heap in Java 8
     #Get heap capacity of JVM
     TotalHeap=$(echo $JSTAT | awk '{ print ($1 + $2 + $5 + $7) / 1024 }')
@@ -88,6 +94,7 @@ do
     echo "JVMs.$SCHEME.$project.Perm_Capacity $TotalPerm `date '+%s'`"
     echo "JVMs.$SCHEME.$project.Perm_Util $UsedPerm `date '+%s'`"
   fi
+  echo "JVMs.$SCHEME.$project.Max_Heap $MaxHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Committed_Heap $TotalHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Heap_Util $UsedHeap `date '+%s'`"
   echo "JVMs.$SCHEME.$project.Eden_Util $ParEden `date '+%s'`"