Fix Load Configuration error Fixes #232

Author: semuadmin

RELEASE_NOTES.md

@@ -2,6 +2,12 @@
 
 ### RELEASE 1.6.0
 
+FIXES:
+
+1. Fix Load Configuration error \#232 `AttributeError: 'tuple' object has no attribute 'upper'`.
+
+ENHANCEMENTS:
+
 1. Add user-selectable Signals widget, displaying individual GNSS PRN / Signal ID levels and (where applicable) correction sources (receiver must support UBX NAV-SIG messages). Provides greater granularity than the existing Levels widget for UBX devices. Signal IDs are shown in RINEX format e.g. "L1_C/A", "E5_aQ", etc.
 1. Add user-defined preset import facility to Configuration Load/Save/Record panel (accessed via Menu..Options..Configuration Command Recorder). This allows user to record a sequence of UBX, NMEA or TTY commands as they are sent to the receiver and to import this sequence as a user-defined preset in the PyGPSClient json configuration file. This obviates the need to edit the configuration file manually. Remember to re-save the configuration file to persist the changes.
 1. Add Undock/Dock Settings panel facility, via Menu..View..Undock/Dock Settings. Settings panel can now be undocked from the main application window and displayed as a separate Toplevel dialog. If (*and only if*) non-transient (`transient_dialog_b: 0`), the settings panel can be minimized independently of the main window.

src/pygpsclient/app.py

@@ -122,8 +122,6 @@
     INACTIVE_TIMEOUT,
     INTROTXTNOPORTS,
     KILLSWITCH,
-    LOADCONFIGBAD,
-    LOADCONFIGOK,
     NOTCONN,
     NOWDGSWARN,
     SAVECONFIGBAD,
@@ -499,20 +497,16 @@ def load_config(self):
         if err == "":  # load succeeded
             self.update_widgets()
             for frm in (
-                self.frm_settings,
+                self.frm_settings.frm_settings,
                 self.frm_settings.frm_serial,
                 self.frm_settings.frm_socketclient,
             ):
                 frm.reset()
             self._do_layout()
             if self._nowidgets:
                 self.status_label = (NOWDGSWARN.format(filename), ERRCOL)
-            else:
-                self.status_label = (LOADCONFIGOK.format(filename), OKCOL)
-        elif err == "cancelled":  # user cancelled
-            return
-        else:  # config error
-            self.status_label = (LOADCONFIGBAD.format(filename), ERRCOL)
+        elif err == "cancelled":
+            pass
 
     def save_config(self):
         """
@@ -681,7 +675,6 @@ def update_clients(self, clients: int):
         """
 
         self.server_status = clients
-        # self.frm_settings.frm_socketserver.clients = clients TODO
 
     def _shutdown(self):
         """

src/pygpsclient/configuration.py

@@ -293,6 +293,8 @@ def loadfile(self, filename: str | NoneType = None) -> tuple:
                     resave = True
                     continue
         else:
+            if err == "cancelled":  # user cancelled
+                return filename, err
             if "No such file or directory" in err:
                 err = LOADCONFIGNONE.format(fname)
             else:

src/pygpsclient/file_handler.py

@@ -124,6 +124,7 @@ def load_config(self, filename: Path = CONFIGFILE) -> tuple:
         try:
             if filename is None:
                 filename = self.open_file(
+                    None,
                     "config",
                     (
                         ("config files", "*.json"),

src/pygpsclient/settings_child_frame.py

@@ -58,7 +58,6 @@
     HOME,
     ICON_CONN,
     ICON_DISCONN,
-    ICON_EXIT,
     ICON_LOGREAD,
     ICON_NMEACONFIG,
     ICON_NTRIPCONFIG,

src/pygpsclient/status_frame.py

@@ -36,24 +36,33 @@ def __init__(self, app, *args, **kwargs):
 
         self.width, self.height = self.get_size()
         self._body()
-
-        self.bind("<Configure>", self._on_resize)
+        self._do_layout()
+        self._attach_events()
 
     def _body(self):
         """
         Set up frame and widgets.
         """
 
-        self.grid_rowconfigure(0, weight=1)
-
-        self.option_add("*Font", self.__app.font_md)
-
         self.lbl_connection = Label(self, anchor=W)
         self.lbl_status = Label(self, anchor=W)
+
+    def _do_layout(self):
+        """
+        Position widgets in frame.
+        """
+
         self.lbl_connection.grid(column=0, row=0, sticky=EW)
         ttk.Separator(self, orient=VERTICAL).grid(column=1, row=0, sticky=NS)
         self.lbl_status.grid(column=2, row=0, sticky=EW)
 
+    def _attach_events(self):
+        """
+        Bind events to frame.
+        """
+
+        self.bind("<Configure>", self._on_resize)
+
     def _on_resize(self, event):  # pylint: disable=unused-argument
         """
         Resize frame