Skip to content

Commit be7b4f2

Browse files
Merge pull request #154 from runpod/catch-e2e-results
Update CI-e2e.yml
2 parents 794e7b7 + f35c728 commit be7b4f2

3 files changed

Lines changed: 25 additions & 1 deletion

File tree

.github/workflows/CI-e2e.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,22 @@ jobs:
6363

6464
steps:
6565
- uses: actions/checkout@v4
66+
6667
- name: Run Tests
68+
id: run-tests
6769
uses: direlines/runpod-test-runner@v1.7
6870
with:
6971
image-tag: ${{ vars.DOCKERHUB_REPO }}/${{ vars.DOCKERHUB_IMG }}:${{ needs.e2e-build.outputs.docker_tag }}
7072
runpod-api-key: ${{ secrets.RUNPOD_API_KEY }}
7173
request-timeout: 1200
74+
75+
- name: Verify Tests
76+
env:
77+
TOTAL_TESTS: ${{ steps.run-tests.outputs.total-tests }}
78+
SUCCESSFUL_TESTS: ${{ steps.run-tests.outputs.succeeded }}
79+
run: |
80+
echo "Total tests: $TOTAL_TESTS"
81+
echo "Successful tests: $SUCCESSFUL_TESTS"
82+
if [ "$TOTAL_TESTS" != "$SUCCESSFUL_TESTS" ]; then
83+
exit 1
84+
fi

runpod/serverless/modules/rp_job.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ async def run_job(handler: Callable, job: Dict[str, Any]) -> Dict[str, Any]:
151151

152152
log.error(f'{job["id"]} | Captured Handler Exception')
153153
log.error(json.dumps(error_info, indent=4))
154-
run_result = {"error": error_info}
154+
run_result = {"error": json.dumps(error_info)}
155155

156156
finally:
157157
log.debug(f'{job["id"]} | run_job return: {run_result}')

tests/test_serverless/test_modules/test_job.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,17 @@ async def test_job_with_errors(self):
201201

202202
assert job_result == {"error": "test"}
203203

204+
async def test_job_with_raised_exception(self):
205+
'''
206+
Tests the run_job function with a raised exception
207+
'''
208+
mock_handler = Mock()
209+
mock_handler.side_effect = Exception
210+
211+
job_result = await rp_job.run_job(mock_handler, self.sample_job)
212+
213+
assert "error" in job_result
214+
204215
async def test_job_with_refresh_worker(self):
205216
'''
206217
Tests the run_job function with refresh_worker

0 commit comments

Comments
 (0)