v1.8.8 fix BufferReader readBytes bounds error on views

Author: reececomo

dist/index.cjs

@@ -1,6 +1,6 @@
 {
   "name": "tinybuf",
-  "version": "1.8.7",
+  "version": "1.8.8",
   "author": "Reece Como <reece.como@gmail.com>",
   "authors": [
     "Reece Como <reece.como@gmail.com>",

dist/index.cjs.map

@@ -1,11 +1,21 @@
 import { BufferReader } from "../core/lib/BufferReader";
 
 describe("ReadState", () => {
-  describe("readBuffer(...)", () => {
+  describe("$readBytes(...)", () => {
     it("should throw RangeError when attempting to read beyond the buffer", () => {
       const buffer = new Uint8Array([1, 2, 3]).buffer;
       const data = new BufferReader(buffer);
       expect(() => data.$readBytes(4)).toThrow(RangeError);
     });
+
+    test("regression case: BufferReader throw on a view", () => {
+      const original = new Uint8Array([10, 11, 12, 13, 14, 15]);
+
+      const viewBytes = new Uint8Array(original.buffer, 2, 4);
+      const bufferReader = new BufferReader(viewBytes);
+
+      expect(() => bufferReader.$readBytes(4)).not.toThrow(RangeError);
+      expect(() => bufferReader.$readBytes(6)).toThrow(RangeError);
+    });
   });
 });

dist/index.mjs

@@ -73,11 +73,16 @@ export class BufferReader {
 
   /** @throws RangeError if exceeds length */
   public $readBytes(bytes: number): Uint8Array {
-    if (this._$dataView.byteOffset + this.i + bytes > this._$dataView.byteLength) {
+    if (this.i + bytes > this._$dataView.byteLength) {
       throw new RangeError("exceeded bytes");
     }
 
-    const view = new Uint8Array(this._$dataView.buffer, this._$dataView.byteOffset + this.i, bytes);
+    const view = new Uint8Array(
+      this._$dataView.buffer,
+      this._$dataView.byteOffset + this.i,
+      bytes
+    );
+
     this.i += bytes;
 
     return view;