Skip to content

Commit 7deb8da

Browse files
danezdanez
committed
chore: Upgrade eslint and prettier
1 parent a60ede6 commit 7deb8da

14 files changed

Lines changed: 113 additions & 155 deletions

‎.prettierrc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"arrowParens": "avoid",
2+
"arrowParens": "always",
33
"bracketSpacing": true,
44
"jsxBracketSameLine": false,
55
"printWidth": 80,

‎package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"css-loader": "^3.3.2",
7070
"enzyme": "^3.5.0",
7171
"enzyme-adapter-react-16": "^1.3.0",
72-
"eslint": "^6.7.2",
72+
"eslint": "^7.1.0",
7373
"eslint-config-airbnb": "^18.0.1",
7474
"eslint-config-prettier": "^6.7.0",
7575
"eslint-plugin-import": "^2.14.0",
@@ -86,7 +86,7 @@
8686
"lint-staged": "^10.2.6",
8787
"mini-css-extract-plugin": "^0.9.0",
8888
"npm-run-all": "^4.1.3",
89-
"prettier": "^1.14.2",
89+
"prettier": "^2.0.5",
9090
"react": "^16.4.2",
9191
"react-dom": "^16.4.2",
9292
"react-live": "^1.11.0",

‎src/components/Tab.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export default class Tab extends Component {
7575
[selectedClassName]: selected,
7676
[disabledClassName]: disabled,
7777
})}
78-
ref={node => {
78+
ref={(node) => {
7979
this.node = node;
8080
if (tabRef) tabRef(node);
8181
}}

‎src/components/UncontrolledTabs.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ export default class UncontrolledTabs extends Component {
179179
}
180180

181181
// Map children to dynamically setup refs
182-
return deepMap(children, child => {
182+
return deepMap(children, (child) => {
183183
let result = child;
184184

185185
// Clone TabList and Tab components to have refs
@@ -197,12 +197,12 @@ export default class UncontrolledTabs extends Component {
197197
}
198198

199199
result = cloneElement(child, {
200-
children: deepMap(child.props.children, tab => {
200+
children: deepMap(child.props.children, (tab) => {
201201
const key = `tabs-${listIndex}`;
202202
const selected = selectedIndex === listIndex;
203203

204204
const props = {
205-
tabRef: node => {
205+
tabRef: (node) => {
206206
this.tabNodes[key] = node;
207207
},
208208
id: this.tabIds[listIndex],
@@ -241,7 +241,7 @@ export default class UncontrolledTabs extends Component {
241241
});
242242
}
243243

244-
handleKeyDown = e => {
244+
handleKeyDown = (e) => {
245245
const { direction } = this.props;
246246
if (this.isTabFromContainer(e.target)) {
247247
let { selectedIndex: index } = this.props;
@@ -296,7 +296,7 @@ export default class UncontrolledTabs extends Component {
296296
}
297297
};
298298

299-
handleClick = e => {
299+
handleClick = (e) => {
300300
let node = e.target;
301301
do {
302302
if (this.isTabFromContainer(node)) {
@@ -360,7 +360,7 @@ export default class UncontrolledTabs extends Component {
360360
className={cx(className)}
361361
onClick={this.handleClick}
362362
onKeyDown={this.handleKeyDown}
363-
ref={node => {
363+
ref={(node) => {
364364
this.node = node;
365365
if (domRef) domRef(node);
366366
}}

‎src/components/__tests__/Tab-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function expectToMatchSnapshot(component) {
1111
describe('<Tab />', () => {
1212
beforeAll(() => {
1313
// eslint-disable-next-line no-console
14-
console.error = error => {
14+
console.error = (error) => {
1515
throw new Error(error);
1616
};
1717
});

‎src/components/__tests__/TabList-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function expectToMatchSnapshot(component) {
1414
describe('<TabList />', () => {
1515
beforeAll(() => {
1616
// eslint-disable-next-line no-console
17-
console.error = error => {
17+
console.error = (error) => {
1818
throw new Error(error);
1919
};
2020
});

‎src/components/__tests__/TabPanel-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ function expectToMatchSnapshot(component) {
1111
describe('<TabPanel />', () => {
1212
beforeAll(() => {
1313
// eslint-disable-next-line no-console
14-
console.error = error => {
14+
console.error = (error) => {
1515
throw new Error(error);
1616
};
1717
});

‎src/components/__tests__/Tabs-node-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe('ServerSide <Tabs />', () => {
3333

3434
beforeAll(() => {
3535
// eslint-disable-next-line no-console
36-
console.error = error => {
36+
console.error = (error) => {
3737
throw new Error(error);
3838
};
3939
});

‎src/components/__tests__/Tabs-test.js‎

Lines changed: 17 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ describe('<Tabs />', () => {
5252

5353
beforeAll(() => {
5454
// eslint-disable-next-line no-console
55-
console.error = error => {
55+
console.error = (error) => {
5656
throw new Error(error);
5757
};
5858
});
@@ -81,10 +81,7 @@ describe('<Tabs />', () => {
8181
}),
8282
);
8383

84-
wrapper
85-
.find(Tab)
86-
.at(1)
87-
.simulate('click');
84+
wrapper.find(Tab).at(1).simulate('click');
8885

8986
expect(called.index).toBe(1);
9087
expect(called.last).toBe(0);
@@ -98,7 +95,7 @@ describe('<Tabs />', () => {
9895
let domNode;
9996
mount(
10097
createTabs({
101-
domRef: node => {
98+
domRef: (node) => {
10299
domNode = node;
103100
},
104101
}),
@@ -123,31 +120,21 @@ describe('<Tabs />', () => {
123120
describe('mouse', () => {
124121
test('should update selectedIndex when clicked', () => {
125122
const wrapper = mount(createTabs());
126-
wrapper
127-
.find(Tab)
128-
.at(1)
129-
.simulate('click');
123+
wrapper.find(Tab).at(1).simulate('click');
130124

131125
assertTabSelected(wrapper, 1);
132126
});
133127

134128
test('should update selectedIndex when tab child is clicked', () => {
135129
const wrapper = mount(createTabs());
136-
wrapper
137-
.find(Tab)
138-
.at(2)
139-
.childAt(0)
140-
.simulate('click');
130+
wrapper.find(Tab).at(2).childAt(0).simulate('click');
141131

142132
assertTabSelected(wrapper, 2);
143133
});
144134

145135
test('should not change selectedIndex when clicking a disabled tab', () => {
146136
const wrapper = mount(createTabs({ defaultIndex: 0 }));
147-
wrapper
148-
.find(Tab)
149-
.at(3)
150-
.simulate('click');
137+
wrapper.find(Tab).at(3).simulate('click');
151138

152139
assertTabSelected(wrapper, 0);
153140
});
@@ -198,19 +185,13 @@ describe('<Tabs />', () => {
198185
expect(tabPanels.at(1).text()).toBe('');
199186
expect(tabPanels.at(2).text()).toBe('');
200187

201-
wrapper
202-
.find(Tab)
203-
.at(1)
204-
.simulate('click');
188+
wrapper.find(Tab).at(1).simulate('click');
205189

206190
expect(tabPanels.at(0).text()).toBe('');
207191
expect(tabPanels.at(1).text()).toBe('Hello Bar');
208192
expect(tabPanels.at(2).text()).toBe('');
209193

210-
wrapper
211-
.find(Tab)
212-
.at(2)
213-
.simulate('click');
194+
wrapper.find(Tab).at(2).simulate('click');
214195

215196
expect(tabPanels.at(0).text()).toBe('');
216197
expect(tabPanels.at(1).text()).toBe('');
@@ -298,7 +279,7 @@ describe('<Tabs />', () => {
298279
const oldConsoleError = console.error; // eslint-disable-line no-console
299280
let catchedError;
300281
// eslint-disable-next-line no-console
301-
console.error = error => {
282+
console.error = (error) => {
302283
catchedError = error;
303284
};
304285
shallow(
@@ -320,7 +301,7 @@ describe('<Tabs />', () => {
320301
const oldConsoleError = console.error; // eslint-disable-line no-console
321302
let catchedError;
322303
// eslint-disable-next-line no-console
323-
console.error = error => {
304+
console.error = (error) => {
324305
catchedError = error;
325306
};
326307
shallow(
@@ -446,11 +427,7 @@ describe('<Tabs />', () => {
446427
</Tabs>,
447428
);
448429

449-
wrapper
450-
.find('Tabs.second')
451-
.find(Tab)
452-
.at(1)
453-
.simulate('click');
430+
wrapper.find('Tabs.second').find(Tab).at(1).simulate('click');
454431

455432
assertTabSelected(wrapper, 0);
456433
assertTabSelected(wrapper.find('Tabs.second'), 1);
@@ -491,16 +468,10 @@ describe('<Tabs />', () => {
491468

492469
assertTabSelected(wrapper, 0);
493470

494-
wrapper
495-
.find(Tab)
496-
.at(1)
497-
.simulate('click');
471+
wrapper.find(Tab).at(1).simulate('click');
498472
assertTabSelected(wrapper, 0);
499473

500-
wrapper
501-
.find(Tab)
502-
.at(2)
503-
.simulate('click');
474+
wrapper.find(Tab).at(2).simulate('click');
504475
assertTabSelected(wrapper, 0);
505476
});
506477

@@ -516,10 +487,7 @@ describe('<Tabs />', () => {
516487

517488
assertTabSelected(wrapper, 0);
518489

519-
wrapper
520-
.find(Tab)
521-
.at(1)
522-
.simulate('click');
490+
wrapper.find(Tab).at(1).simulate('click');
523491
assertTabSelected(wrapper, 1);
524492
expect(wasClicked).toBe(true);
525493
});
@@ -536,10 +504,7 @@ describe('<Tabs />', () => {
536504

537505
assertTabSelected(wrapper, 0);
538506

539-
wrapper
540-
.find(Tab)
541-
.at(0)
542-
.simulate('click');
507+
wrapper.find(Tab).at(0).simulate('click');
543508
assertTabSelected(wrapper, 0);
544509
expect(wasClicked).toBe(true);
545510
});
@@ -561,16 +526,10 @@ describe('<Tabs />', () => {
561526

562527
const wrapper = mount(<Wrap />);
563528

564-
wrapper
565-
.find(Tab)
566-
.at(1)
567-
.simulate('click');
529+
wrapper.find(Tab).at(1).simulate('click');
568530
assertTabSelected(wrapper, 1);
569531

570-
wrapper
571-
.find(Tab)
572-
.at(2)
573-
.simulate('click');
532+
wrapper.find(Tab).at(2).simulate('click');
574533
assertTabSelected(wrapper, 2);
575534
});
576535

‎src/helpers/childrenDeepMap.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ function isTabChild(child) {
66
}
77

88
export function deepMap(children, callback) {
9-
return Children.map(children, child => {
9+
return Children.map(children, (child) => {
1010
// null happens when conditionally rendering TabPanel/Tab
1111
// see https://github.com/reactjs/react-tabs/issues/37
1212
if (child === null) return null;
@@ -32,7 +32,7 @@ export function deepMap(children, callback) {
3232
}
3333

3434
export function deepForEach(children, callback) {
35-
return Children.forEach(children, child => {
35+
return Children.forEach(children, (child) => {
3636
// null happens when conditionally rendering TabPanel/Tab
3737
// see https://github.com/reactjs/react-tabs/issues/37
3838
if (child === null) return;

0 commit comments

Comments
 (0)