Merge branch 'bugfix/dashboard_card_empty' into develop

Author: btry

install/data/report_dashboard.json

@@ -116,14 +116,14 @@
             "limit": "7"
         }
     },
-    "plugin_carbon_report_usage_abiotic_depletion": {
+    "plugin_carbon_report_usage_adp_impact": {
         "x": 10,
         "y": 3,
         "width": 5,
         "height": 3,
         "card_options": {
             "color": "#fccd3e",
-            "widgettype": "usage_abiotic_depletion",
+            "widgettype": "impact_criteria_number",
             "use_gradient": "0",
             "point_labels": "0",
             "limit": "7"

tests/install/PluginInstallTest.php

@@ -42,6 +42,7 @@
 use DbUtils;
 use DisplayPreference;
 use Glpi\Dashboard\Dashboard;
+use Glpi\Dashboard\Grid;
 use Glpi\Dashboard\Item;
 use Glpi\Dashboard\Right;
 use Glpi\DBAL\QueryExpression as QueryExpression;
@@ -67,6 +68,7 @@
 use NetworkEquipmentType;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\CoversNothing;
+use PHPUnit\Framework\Attributes\Depends;
 use Plugin;
 use Profile;
 use ProfileRight;
@@ -117,7 +119,8 @@ protected function executeInstallation()
         ob_start();
         $plugin->install($plugin->fields['id']);
         $install_output = ob_get_clean();
-        $this->assertTrue($plugin->isInstalled($plugin_name), $install_output);
+        $session_messages = implode(PHP_EOL, $_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR] ?? []);
+        $this->assertTrue($plugin->isInstalled($plugin_name), $install_output . PHP_EOL . $session_messages);
 
         // Enable the plugin
         $success = $plugin->activate($plugin->fields['id']);
@@ -144,7 +147,6 @@ public function testInstallPlugin()
 
         $this->checkConfig();
         $this->checkAutomaticAction();
-        $this->checkDashboard();
         $this->checkRights();
         $this->checkInitialDataSources();
         $this->checkInitialZones();
@@ -510,7 +512,7 @@ private function checkPredefinedUsageProfiles()
         $this->assertEquals(2, count($rows));
     }
 
-    public function checkBuitFiles()
+    public function checkBuiltFiles()
     {
         global $PLUGIN_HOOKS;
 
@@ -523,7 +525,8 @@ public function checkBuitFiles()
         $this->assertTrue(in_array('lib/apexcharts.js', $PLUGIN_HOOKS[Hooks::ADD_JAVASCRIPT]['carbon']));
     }
 
-    public function checkDashboard()
+    #[Depends('testInstallPlugin')]
+    public function test_dashboard_is_configured()
     {
         /** @var DBmysql $DB */
         global $DB;
@@ -581,6 +584,16 @@ public function checkDashboard()
             'dashboards_dashboards_id' => $dashboard->fields['id'],
         ]);
         $this->assertCount($expected_cards_count, $rows);
+
+        // Check that all cards actually generate a valid content
+        // Let the plugin believe we are viewing the reporting page
+        $_SERVER['REQUEST_URI'] = 'https://localhost/carbon/front/report.php';
+        $grid = new Grid();
+        foreach ($rows as $row) {
+            $dashboardItem->getFromDB($row['id']);
+            $html = $grid->getCardHtml($row['card_id'], ['args' => json_decode($row['card_options'], true)]);
+            $this->assertStringNotContainsString('empty card!', $html, "Card with id {$row['card_id']} returns empty content");
+        }
     }
 
     private $zones = [