fix(UsageImpact): allow reset if only gwp was calculated

Author: btry

front/usageimpact.form.php

@@ -60,14 +60,20 @@
     );
     Html::back();
 } else if (isset($_POST['reset'])) {
-    if (!isset($_POST['id'])) {
+    if (!isset($_POST['itemtype']) || !isset($_POST['items_id'])) {
         Session::addMessageAfterRedirect(__('Missing arguments in request.', 'carbon'), false, ERROR);
         Html::back();
     }
     $usage_impact = new UsageImpact();
-    $usage_impact->check($_POST['id'], PURGE);
+    $usage_impact->getFromDBByCrit([
+        'itemtype' => $_POST['itemtype'],
+        'items_id' => $_POST['items_id'],
+    ]);
+    if (!$usage_impact->isNewItem()) {
+        $usage_impact->check($usage_impact->getID(), PURGE);
+    }
 
-    $gwp_impact_class = '\\GlpiPlugin\\Carbon\\Impact\\History\\' . $usage_impact->fields['itemtype'];
+    $gwp_impact_class = '\\GlpiPlugin\\Carbon\\Impact\\History\\' . $_POST['itemtype'];
     if (!class_exists($gwp_impact_class) || !is_subclass_of($gwp_impact_class, AbstractAsset::class)) {
         Session::addMessageAfterRedirect(__('Bad arguments.', 'carbon'), false, ERROR);
         Html::back();
@@ -77,17 +83,17 @@
     $gwp_impact = new $gwp_impact_class();
     $itemtype = $gwp_impact->getItemtype();
     $item = new $itemtype();
-    $item->getFromDB($usage_impact->fields['items_id']);
+    $item->getFromDB($_POST['items_id']);
     if (!$item->canUpdateItem()) {
         Session::addMessageAfterRedirect(__('Reset denied.', 'carbon'), false, ERROR);
         Html::back();
     }
 
-    if (!$gwp_impact->resetForItem($usage_impact->fields['items_id'])) {
+    if (!$gwp_impact->resetForItem($item->getID())) {
         Session::addMessageAfterRedirect(__('Reset failed.', 'carbon'), false, ERROR);
     }
 
-    if (!$usage_impact->delete($usage_impact->fields)) {
+    if (!$usage_impact->isNewItem() && !$usage_impact->delete($usage_impact->fields)) {
         Session::addMessageAfterRedirect(__('Delete of usage impact failed.', 'carbon'), false, ERROR);
     }
 } else if (isset($_POST['calculate'])) {

src/UsageInfo.php

@@ -204,6 +204,10 @@ public static function showCharts(CommonDBTM $asset)
             // TODO: decide if we show or not this impact.
             unset($usage_impact->fields['pe']);
         }
+        $usage_carbon_emission_count = countElementsInTable(CarbonEmission::getTable(), [
+            'itemtype' => $asset->getType(),
+            'items_id' => $asset->getID(),
+        ]);
 
         $data = Provider::getUsageCarbonEmissionPerMonth([
             'itemtype' => $asset->getType(),
@@ -248,6 +252,7 @@ public static function showCharts(CommonDBTM $asset)
         TemplateRenderer::getInstance()->display('@carbon/environmentalimpact-item.html.twig', [
             'usage_info'      => $usage_info,
             'asset'           => $asset,
+            'usage_carbon_emission_count' => $usage_carbon_emission_count,
             'embodied_impact' => $embodied_impact,
             'usage_impact'    => $usage_impact,
             'usage_carbon_emission_graph' => Widget::DisplayGraphUsageCarbonEmissionPerMonth($data),

templates/environmentalimpact-item.html.twig

@@ -58,8 +58,8 @@
 </div>
 
 <div>
-  {% if not usage_impact.isNewItem() %}
-    {% set reset_args = "{_glpi_csrf_token: '" ~ csrf_token() ~ "', reset: '', id: '" ~ usage_impact.getID() ~ "'}" %}
+  {% if not usage_impact.isNewItem() or usage_carbon_emission_count > 0 %}
+    {% set reset_args = "{_glpi_csrf_token: '" ~ csrf_token() ~ "', reset: '', itemtype: '" ~ asset.getType() ~ "', items_id: '" ~ asset.getID() ~ "'}" %}
     <a class="btn btn-primary" onclick="submitGetLink('{{ usage_impact_action_url}}', {{ reset_args }})">{{ __('Reset data', 'carbon') }}</a>
   {% endif %}
   {% set calculate_args = "{_glpi_csrf_token: '" ~ csrf_token() ~ "', calculate: '', itemtype: '" ~ asset.getType() ~ "', items_id: '" ~ asset.getID() ~ "'}" %}