v8.5.6: add two internal session variable info: InPacketBytes, OutPacketBytes (#22508)#22736
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
do-not-merge/hold
|
@yibin87 This PR has conflicts, I have hold it. |
ti-chi-bot
added
size/XS
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
lgtm
type/cherry-pick-for-release-8.5
ti-chi-bot
bot
added
size/S
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the InPacketBytes, max_user_connections, and OutPacketBytes system variables. The review feedback identifies critical issues, including the presence of Git conflict markers in the documentation and several style guide violations. Specifically, the documentation needs to use the second person ("you") when addressing users, use the present tense, and ensure variable names are enclosed in backticks.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ti-chi-bot
bot
added
size/XS
qiancai
removed
the
do-not-merge/hold
qiancai
changed the title
|
@yibin87: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
merged commit 5b7cea5
into
pingcap:feature/preview-v8.5.6
3 participants
This is an automated cherry-pick of #22508
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Add two internal session variable info docs-cn#21400
Do your changes match any of the following descriptions?