refactor(tests): remove PHP version check for --parallel option in TestsCommand

Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>

Author: coisa

composer.json

@@ -26,6 +26,7 @@
     "require": {
         "php": "^8.3",
         "composer-plugin-api": "^2.0",
+        "brianium/paratest": "^7.17",
         "composer/composer": "^2.9",
         "dg/bypass-finals": "^1.9",
         "ergebnis/composer-normalize": "^2.50",
@@ -54,8 +55,7 @@
         "symfony/var-dumper": "^7.4",
         "symfony/var-exporter": "^7.4",
         "symplify/easy-coding-standard": "^13.0",
-        "thecodingmachine/safe": "^3.4",
-        "brianium/paratest": "^7.17"
+        "thecodingmachine/safe": "^3.4"
     },
     "minimum-stability": "stable",
     "autoload": {

src/Command/SkillsCommand.php

@@ -19,7 +19,6 @@
 namespace FastForward\DevTools\Command;
 
 use FastForward\DevTools\Agent\Skills\SkillsSynchronizer;
-use FastForward\DevTools\Agent\Skills\SynchronizeResult;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Filesystem\Filesystem;
@@ -123,7 +122,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $this->synchronizer->setLogger($this->getIO());
 
-        /** @var SynchronizeResult $result */
         $result = $this->synchronizer->synchronize($skillsDir, $packageSkillsPath);
 
         if ($result->failed()) {

src/Command/TestsCommand.php

@@ -135,19 +135,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $parallel = null !== $input->getOption('parallel');
 
-        if ($parallel) {
-            if (version_compare(PHP_VERSION, '8.5.0', '>=')) {
-                $output->writeln('<warning>--parallel is not compatible with PHP ' . PHP_VERSION . '. Running tests with PHPUnit instead...</warning>');
-                $parallel = false;
-            }
-        }
-
-        $command = $this->getAbsolutePath(sprintf(
-            'vendor/bin/%s',
-            $parallel ? 'paratest' : 'phpunit'
-        ));
+        $command = $this->getAbsolutePath(\sprintf('vendor/bin/%s', $parallel ? 'paratest' : 'phpunit'));
 
-        if (!$parallel) {
+        if (! $parallel) {
             $arguments[] = '--display-deprecations';
             $arguments[] = '--display-phpunit-deprecations';
             $arguments[] = '--display-incomplete';

src/GitAttributes/Merger.php

@@ -79,6 +79,7 @@ public function merge(string $existingContent, array $exportIgnoreEntries, array
             if (isset($keptExportLookup[$pathKey])) {
                 continue;
             }
+
             if (isset($exportIgnoreLines[$pathKey])) {
                 continue;
             }
@@ -149,8 +150,8 @@ private function parseExistingLines(string $content): array
 
         $lines = [];
 
-        foreach (preg_split('/\R/', $content) ?: [] as $line) {
-            $trimmedLine = trim($line);
+        foreach (preg_split('/\R/', $content) as $line) {
+            $trimmedLine = trim((string) $line);
 
             if ('' === $trimmedLine) {
                 continue;

src/GitAttributes/Writer.php

@@ -62,8 +62,9 @@ private function format(string $content): string
     {
         $rows = [];
         $maxPathSpecLength = 0;
+        $lines = preg_split('/\R/', $content);
 
-        foreach (preg_split('/\R/', $content) ?: [] as $line) {
+        foreach ($lines as $line) {
             $trimmedLine = trim((string) $line);
 
             if ('' === $trimmedLine) {