feat(tests): add CoverageSummaryTest for coverage validation

Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>

Author: coisa

src/Command/SkillsCommand.php

@@ -19,7 +19,6 @@
 namespace FastForward\DevTools\Command;
 
 use FastForward\DevTools\Agent\Skills\SkillsSynchronizer;
-use FastForward\DevTools\Agent\Skills\SynchronizeResult;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Filesystem\Filesystem;
@@ -123,7 +122,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $this->synchronizer->setLogger($this->getIO());
 
-        /** @var SynchronizeResult $result */
         $result = $this->synchronizer->synchronize($skillsDir, $packageSkillsPath);
 
         if ($result->failed()) {

src/Command/TestsCommand.php

@@ -127,8 +127,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         try {
             $minimumCoverage = $this->resolveMinimumCoverage($input);
-        } catch (InvalidArgumentException $exception) {
-            $output->writeln('<error>' . $exception->getMessage() . '</error>');
+        } catch (InvalidArgumentException $invalidArgumentException) {
+            $output->writeln('<error>' . $invalidArgumentException->getMessage() . '</error>');
 
             return self::FAILURE;
         }
@@ -259,8 +259,8 @@ private function validateMinimumCoverage(
     ): int {
         try {
             $coverageSummary = $this->coverageSummaryLoader->load($coverageReportPath);
-        } catch (RuntimeException $exception) {
-            $output->writeln('<error>' . $exception->getMessage() . '</error>');
+        } catch (RuntimeException $runtimeException) {
+            $output->writeln('<error>' . $runtimeException->getMessage() . '</error>');
 
             return self::FAILURE;
         }

src/GitAttributes/Merger.php

@@ -79,6 +79,7 @@ public function merge(string $existingContent, array $exportIgnoreEntries, array
             if (isset($keptExportLookup[$pathKey])) {
                 continue;
             }
+
             if (isset($exportIgnoreLines[$pathKey])) {
                 continue;
             }
@@ -149,8 +150,8 @@ private function parseExistingLines(string $content): array
 
         $lines = [];
 
-        foreach (preg_split('/\R/', $content) ?: [] as $line) {
-            $trimmedLine = trim($line);
+        foreach (preg_split('/\R/', $content) as $line) {
+            $trimmedLine = trim((string) $line);
 
             if ('' === $trimmedLine) {
                 continue;

src/GitAttributes/Writer.php

@@ -63,7 +63,7 @@ private function format(string $content): string
         $rows = [];
         $maxPathSpecLength = 0;
 
-        foreach (preg_split('/\R/', $content) ?: [] as $line) {
+        foreach (preg_split('/\R/', $content) as $line) {
             $trimmedLine = trim((string) $line);
 
             if ('' === $trimmedLine) {

tests/Command/TestsCommandTest.php

@@ -47,10 +47,7 @@ final class TestsCommandTest extends AbstractCommandTestCase
      */
     protected function getCommandClass(): TestsCommand
     {
-        return new TestsCommand(
-            $this->filesystem->reveal(),
-            $this->coverageSummaryLoader->reveal(),
-        );
+        return new TestsCommand($this->filesystem->reveal(), $this->coverageSummaryLoader->reveal());
     }
 
     /**

tests/PhpUnit/Coverage/CoverageSummaryTest.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * This file is part of fast-forward/dev-tools.
+ *
+ * This source file is subject to the license bundled
+ * with this source code in the file LICENSE.
+ *
+ * @copyright Copyright (c) 2026 Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
+ * @license   https://opensource.org/licenses/MIT MIT License
+ *
+ * @see       https://github.com/php-fast-forward/dev-tools
+ * @see       https://github.com/php-fast-forward
+ * @see       https://datatracker.ietf.org/doc/html/rfc2119
+ */
+
+namespace FastForward\DevTools\PhpUnit\Coverage;
+
+use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
+
+#[CoversClass(CoverageSummary::class)]
+class CoverageSummaryTest extends TestCase
+{
+    /**
+     * @return array
+     */
+    public static function provideCoverageData(): array
+    {
+        return [[0, 0, 100.0], [50, 200, 25.0], [1, 3, 33.33333333333333]];
+    }
+
+    /**
+     * @param int $executed
+     * @param int $executable
+     * @param float $expectedPercentage
+     *
+     * @return void
+     */
+    #[Test]
+    #[DataProvider('provideCoverageData')]
+    public function executedLinesReturnsValue(int $executed, int $executable, float $expectedPercentage): void
+    {
+        $summary = new CoverageSummary($executed, $executable);
+        self::assertSame($executed, $summary->executedLines());
+    }
+}