refactor: remove redundant intermediate variables in Detector classes

  Simplify code by directly accessing API from extractor property instead of
  using intermediate  variable across multiple adapter detectors

Author: sasezaki

src/Adapters/Archive/Detectors/AuthorName.php

@@ -12,8 +12,7 @@ class AuthorName extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('metadata', 'creator');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/Archive/Detectors/Description.php

@@ -12,8 +12,7 @@ class Description extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('metadata', 'extract');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/Archive/Detectors/PublishedTime.php

@@ -13,8 +13,7 @@ class PublishedTime extends Detector
 {
     public function detect(): ?DateTime
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $fields = ['publicdate', 'addeddate', 'date'];
         foreach ($fields as $field) {

src/Adapters/Archive/Detectors/Title.php

@@ -12,8 +12,7 @@ class Title extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('metadata', 'title');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/Gist/Detectors/AuthorName.php

@@ -12,8 +12,7 @@ class AuthorName extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('owner');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/Gist/Detectors/Code.php

@@ -20,8 +20,7 @@ public function detect(): ?EmbedCode
 
     private function fallback(): ?EmbedCode
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $code = $api->html('div');
         $stylesheet = $api->str('stylesheet');

src/Adapters/Gist/Detectors/PublishedTime.php

@@ -13,8 +13,7 @@ class PublishedTime extends Detector
 {
     public function detect(): ?DateTime
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->time('created_at');
         return $result !== null ? $result : parent::detect();

src/Adapters/ImageShack/Detectors/AuthorName.php

@@ -13,8 +13,7 @@ class AuthorName extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('owner', 'username');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/ImageShack/Detectors/Description.php

@@ -12,8 +12,7 @@ class Description extends Detector
 {
     public function detect(): ?string
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->str('description');
         return (is_string($result) && trim($result) !== '') ? $result : parent::detect();

src/Adapters/ImageShack/Detectors/Image.php

@@ -13,8 +13,7 @@ class Image extends Detector
 {
     public function detect(): ?UriInterface
     {
-        $extractor = $this->extractor;
-        $api = $extractor->getApi();
+        $api = $this->extractor->getApi();
 
         $result = $api->url('direct_link');
         return $result !== null ? $result : parent::detect();