fix: Add exception handling to prevent approval status rollback

Wrap post-approval actions (execute_post_approval_updates,
execute_post_submission_actions, execute_file_workflow_hooks) with
try/except blocks in _finalize_submission() and _reject_submission()
to prevent failures in these non-critical operations from rolling back
the submission status update.

This fixes an issue where approval/rejection would be recorded on the
task but the submission status would remain unchanged if any post-action
failed (e.g., Celery broker unavailable).

Bump version to 0.6.5

Author: matteius

django_forms_workflows/__init__.py

@@ -3,7 +3,7 @@
 Enterprise-grade, database-driven form builder with approval workflows
 """
 
-__version__ = "0.6.4"
+__version__ = "0.6.5"
 __author__ = "Django Forms Workflows Contributors"
 __license__ = "LGPL-3.0-only"
 

django_forms_workflows/workflow_engine.py

@@ -65,9 +65,23 @@ def _finalize_submission(submission: FormSubmission) -> None:
     # Cancel any remaining pending tasks
     submission.approval_tasks.filter(status="pending").update(status="skipped")
 
-    execute_post_approval_updates(submission)
-    execute_post_submission_actions(submission, "on_complete")
-    execute_file_workflow_hooks(submission, "on_approve")
+    # Execute post-approval actions with exception handling to prevent
+    # failures from affecting the submission status update
+    try:
+        execute_post_approval_updates(submission)
+    except Exception as e:
+        logger.error("Error in execute_post_approval_updates: %s", e, exc_info=True)
+
+    try:
+        execute_post_submission_actions(submission, "on_complete")
+    except Exception as e:
+        logger.error("Error in execute_post_submission_actions: %s", e, exc_info=True)
+
+    try:
+        execute_file_workflow_hooks(submission, "on_approve")
+    except Exception as e:
+        logger.error("Error in execute_file_workflow_hooks: %s", e, exc_info=True)
+
     _notify_final_approval(submission)
 
 
@@ -80,15 +94,30 @@ def _reject_submission(submission: FormSubmission, reason: str = "") -> None:
     # Cancel any remaining pending tasks
     submission.approval_tasks.filter(status="pending").update(status="skipped")
 
-    # Execute rejection actions
-    execute_post_submission_actions(submission, "on_reject")
-    execute_file_workflow_hooks(submission, "on_reject")
+    # Execute rejection actions with exception handling to prevent
+    # failures from affecting the submission status update
+    try:
+        execute_post_submission_actions(submission, "on_reject")
+    except Exception as e:
+        logger.error(
+            "Error in execute_post_submission_actions (on_reject): %s", e, exc_info=True
+        )
+
+    try:
+        execute_file_workflow_hooks(submission, "on_reject")
+    except Exception as e:
+        logger.error(
+            "Error in execute_file_workflow_hooks (on_reject): %s", e, exc_info=True
+        )
 
     # Mark all managed files as rejected
-    for managed_file in submission.managed_files.filter(
-        is_current=True, status="pending"
-    ):
-        managed_file.mark_rejected(notes=reason)
+    try:
+        for managed_file in submission.managed_files.filter(
+            is_current=True, status="pending"
+        ):
+            managed_file.mark_rejected(notes=reason)
+    except Exception as e:
+        logger.error("Error marking managed files as rejected: %s", e, exc_info=True)
 
 
 # --- Public API -------------------------------------------------------------

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-forms-workflows"
-version = "0.6.4"
+version = "0.6.5"
 description = "Enterprise-grade, database-driven form builder with approval workflows and external data integration"
 license = "LGPL-3.0-only"
 readme = "README.md"