v0.5.10: Remove JS spinner - just use standard form submission

Author: matteius

django_forms_workflows/__init__.py

@@ -3,7 +3,7 @@
 Enterprise-grade, database-driven form builder with approval workflows
 """
 
-__version__ = "0.5.9"
+__version__ = "0.5.10"
 __author__ = "Django Forms Workflows Contributors"
 __license__ = "LGPL-3.0-only"
 

django_forms_workflows/templates/django_forms_workflows/approve.html

@@ -75,9 +75,7 @@ <h5 class="mb-0">Your Decision</h5>
                         <label for="comments" class="form-label">Comments (Optional)</label>
                         <textarea class="form-control" id="comments" name="comments" rows="3" placeholder="Add any comments about your decision..."></textarea>
                     </div>
-
-                    <!-- Action buttons (shown initially) -->
-                    <div class="d-grid gap-2 d-md-block" id="actionButtons">
+                    <div class="d-grid gap-2 d-md-block">
                         <button type="submit" name="decision" value="approve" class="btn btn-success btn-lg">
                             <i class="bi bi-check-circle"></i> Approve
                         </button>
@@ -88,57 +86,12 @@ <h5 class="mb-0">Your Decision</h5>
                             <i class="bi bi-arrow-left"></i> Back
                         </a>
                     </div>
-
-                    <!-- Loading spinner (hidden initially) -->
-                    <div class="d-none" id="loadingSpinner">
-                        <div class="d-flex align-items-center">
-                            <div class="spinner-border text-primary me-3" role="status">
-                                <span class="visually-hidden">Processing...</span>
-                            </div>
-                            <div>
-                                <strong id="loadingText">Processing your decision...</strong>
-                                <p class="text-muted mb-0 small">This may take a few moments.</p>
-                            </div>
-                        </div>
-                    </div>
                 </form>
             </div>
         </div>
     </div>
 </div>
 {% endblock %}
 
-{% block extra_js %}
-<script>
-document.addEventListener('DOMContentLoaded', function() {
-    const form = document.getElementById('approvalForm');
-    const actionButtons = document.getElementById('actionButtons');
-    const loadingSpinner = document.getElementById('loadingSpinner');
-    const loadingText = document.getElementById('loadingText');
-
-    form.addEventListener('submit', function(e) {
-        // Get the clicked button's value
-        const clickedButton = e.submitter;
-        const decision = clickedButton ? clickedButton.value : 'processing';
 
-        // Update loading text based on decision
-        if (decision === 'approve') {
-            loadingText.textContent = 'Approving submission...';
-        } else if (decision === 'reject') {
-            loadingText.textContent = 'Rejecting submission...';
-        }
-
-        // Hide buttons, show spinner
-        actionButtons.classList.add('d-none');
-        loadingSpinner.classList.remove('d-none');
-
-        // Disable only buttons to prevent double-click (not inputs - that breaks CSRF)
-        const buttons = form.querySelectorAll('button');
-        buttons.forEach(function(btn) {
-            btn.disabled = true;
-        });
-    });
-});
-</script>
-{% endblock %}
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-forms-workflows"
-version = "0.5.9"
+version = "0.5.10"
 description = "Enterprise-grade, database-driven form builder with approval workflows and external data integration"
 license = "LGPL-3.0-only"
 readme = "README.md"