Merge pull request #129 from ooni/fix-range

Fix the build_timestamps function for ranges starting at midnight

Author: hellais

oonipipeline/src/oonipipeline/cli/utils.py

@@ -30,7 +30,6 @@ def build_timestamps(
     while current < end_at:
         if (
             current.hour == 0
-            and current != start_at
             and current < end_at.replace(hour=0)
         ):
             timestamps.append((current.strftime("%Y-%m-%d"), current))

oonipipeline/tests/test_cli.py

@@ -96,6 +96,14 @@ def test_build_timestamps_long():
         map(lambda x: x[0], result)
     )  # Complete day in the middle
 
+def test_build_timestamps_long_2():
+    start = datetime.strptime("2024-01-01", "%Y-%m-%d")
+    end = datetime.strptime("2024-02-01", "%Y-%m-%d")
+    result = build_timestamps(start, end)
+
+    assert result[0][0] == "2024-01-01"  # First day
+    assert result[-1][0] == "2024-01-31"  # Last day
+    assert len(result) == 31
 
 def test_build_timestamps_single_day():
     start = datetime.strptime("2024-01-01 01", "%Y-%m-%d %H")
@@ -111,7 +119,7 @@ def test_build_timestamps_midnight():
     end = datetime.strptime("2024-01-03 00", "%Y-%m-%d %H")
     result = build_timestamps(start, end)
 
-    assert result[0][0] == "2024-01-01T00"
+    assert result[0][0] == "2024-01-01"
     assert "2024-01-02" in list(map(lambda x: x[0], result))
     assert result[-1][0] == "2024-01-02"