Skip to content

Commit 065e282

Browse files
committed
AC review
1 parent 02201d2 commit 065e282

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

pymongo/asynchronous/mongo_client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2853,9 +2853,8 @@ async def run(self) -> T:
28532853
exc_code = getattr(exc, "code", None)
28542854
overloaded = exc.has_error_label("SystemOverloadedError")
28552855
always_retryable = exc.has_error_label("RetryableError") and overloaded
2856-
if (
2857-
not self._client.options.retry_reads
2858-
or not always_retryable
2856+
if not self._client.options.retry_reads or (
2857+
not always_retryable
28592858
and (
28602859
self._is_not_eligible_for_retry()
28612860
or (
@@ -2934,7 +2933,7 @@ async def run(self) -> T:
29342933

29352934
self._always_retryable = always_retryable
29362935
if overloaded:
2937-
delay = self._retry_policy.backoff(self._attempt_number) if overloaded else 0
2936+
delay = self._retry_policy.backoff(self._attempt_number)
29382937
if not await self._retry_policy.should_retry(self._attempt_number, delay):
29392938
if exc_to_check.has_error_label("NoWritesPerformed") and self._last_error:
29402939
raise self._last_error from exc

pymongo/synchronous/mongo_client.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2843,9 +2843,8 @@ def run(self) -> T:
28432843
exc_code = getattr(exc, "code", None)
28442844
overloaded = exc.has_error_label("SystemOverloadedError")
28452845
always_retryable = exc.has_error_label("RetryableError") and overloaded
2846-
if (
2847-
not self._client.options.retry_reads
2848-
or not always_retryable
2846+
if not self._client.options.retry_reads or (
2847+
not always_retryable
28492848
and (
28502849
self._is_not_eligible_for_retry()
28512850
or (
@@ -2924,7 +2923,7 @@ def run(self) -> T:
29242923

29252924
self._always_retryable = always_retryable
29262925
if overloaded:
2927-
delay = self._retry_policy.backoff(self._attempt_number) if overloaded else 0
2926+
delay = self._retry_policy.backoff(self._attempt_number)
29282927
if not self._retry_policy.should_retry(self._attempt_number, delay):
29292928
if exc_to_check.has_error_label("NoWritesPerformed") and self._last_error:
29302929
raise self._last_error from exc

0 commit comments

Comments
 (0)