fix: update msal dependencies (#3548)

gavinbarron · ramsessanchez · web-flow · commit 98069176fe14 · 2026-03-06T09:09:10.000Z
* fix: update msal dependencies

* revert debug testing change

---------

Co-authored-by: Ramses Sanchez-Hernandez &lt;63934382+ramsessanchez@users.noreply.github.com&gt;
diff --git a/src/Authentication/Authentication.Core/Microsoft.Graph.Authentication.Core.csproj b/src/Authentication/Authentication.Core/Microsoft.Graph.Authentication.Core.csproj
@@ -4,7 +4,7 @@
     <LangVersion>9.0</LangVersion>
     <TargetFrameworks>netstandard2.0;net6.0;net472</TargetFrameworks>
     <RootNamespace>Microsoft.Graph.PowerShell.Authentication.Core</RootNamespace>
-    <Version>2.32.0</Version>
+    <Version>2.35.1</Version>
     <!-- Suppress .NET Target Framework Moniker (TFM) Support Build Warnings -->
     <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
   </PropertyGroup>
@@ -13,11 +13,14 @@
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Azure.Identity" Version="1.17.1" />
-    <PackageReference Include="Azure.Identity.Broker" Version="1.3.1" />
+    <PackageReference Include="Azure.Identity" Version="1.18.0" />
+    <PackageReference Include="Azure.Identity.Broker" Version="1.4.0" />
+    <!-- Explicitly reference Microsoft.Identity.Client to ensure form_post support -->
+    <PackageReference Include="Microsoft.Identity.Client" Version="4.82.1" />
+    <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.3" />
     <PackageReference Include="Microsoft.Graph.Core" Version="3.2.5" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
-    <PackageReference Include="System.Text.Json" Version="8.0.6" />
+    <PackageReference Include="System.Text.Json" Version="10.0.3" />
   </ItemGroup>
   <Target Name="CopyFiles" AfterTargets="Build">
     <Copy SourceFiles="@(PreLoadAssemblies)" DestinationFolder="$(OutputPath)/publish" />
diff --git a/src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs b/src/Authentication/Authentication.Core/Utilities/AuthenticationHelpers.cs
@@ -78,8 +78,8 @@ private static async Task<TokenCredential> GetEnvironmentCredentialAsync(IAuthCo
 
         private static bool IsAuthFlowNotSupported()
         {
-            return ((!string.IsNullOrEmpty(EnvironmentVariables.Username) && !string.IsNullOrEmpty(EnvironmentVariables.Password))
-                && (string.IsNullOrEmpty(EnvironmentVariables.ClientSecret) && string.IsNullOrEmpty(EnvironmentVariables.ClientCertificatePath)));
+            return !string.IsNullOrEmpty(EnvironmentVariables.Username) && !string.IsNullOrEmpty(EnvironmentVariables.Password)
+                && string.IsNullOrEmpty(EnvironmentVariables.ClientSecret) && string.IsNullOrEmpty(EnvironmentVariables.ClientCertificatePath);
         }
 
         private static bool ShouldUseWam(IAuthContext authContext)
@@ -138,7 +138,7 @@ private static async Task<InteractiveBrowserCredential> GetInteractiveBrowserCre
                     {
                         return interactiveBrowserCredential.AuthenticateAsync(new TokenRequestContext(authContext.Scopes), cancellationToken);
                     });
-                }        
+                }
                 await WriteAuthRecordAsync(authRecord).ConfigureAwait(false);
                 return interactiveBrowserCredential;
             }
diff --git a/src/Authentication/Authentication.Test/Microsoft.Graph.Authentication.Test.csproj b/src/Authentication/Authentication.Test/Microsoft.Graph.Authentication.Test.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <TargetFrameworks>net8.0;net472</TargetFrameworks>
     <IsPackable>false</IsPackable>
-    <Version>2.32.0</Version>
+    <Version>2.35.1</Version>
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.2" />
diff --git a/src/Authentication/Authentication/Microsoft.Graph.Authentication.csproj b/src/Authentication/Authentication/Microsoft.Graph.Authentication.csproj
@@ -10,7 +10,7 @@
     <WarningsAsErrors />
     <NuspecFile>Microsoft.Graph.Authentication.nuspec</NuspecFile>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
-    <Version>2.32.0</Version>
+    <Version>2.35.1</Version>
   </PropertyGroup>
   <PropertyGroup>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
diff --git a/src/Authentication/Authentication/Microsoft.Graph.Authentication.nuspec b/src/Authentication/Authentication/Microsoft.Graph.Authentication.nuspec
@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <package>
   <metadata>
-    <version>2.32.0</version>
+    <version>2.35.1</version>
     <id>Microsoft.Graph.Authentication</id>
     <description>Microsoft Graph PowerShell authentication module</description>
     <authors>Microsoft</authors>
@@ -36,9 +36,12 @@
     <file src="artifacts\Dependencies\Microsoft.IdentityModel.Abstractions.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.Buffers.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.ClientModel.dll" target="Dependencies" />
+    <file src="artifacts\Dependencies\System.Diagnostics.DiagnosticSource.dll" target="Dependencies" />
+    <file src="artifacts\Dependencies\System.IO.Pipelines.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.Memory.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.Memory.Data.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.Text.Json.dll" target="Dependencies" />
+    <file src="artifacts\Dependencies\System.Text.Encodings.Web.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\System.Threading.Tasks.Extensions.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\Microsoft.Kiota.Abstractions.dll" target="Dependencies" />
     <file src="artifacts\Dependencies\Microsoft.Kiota.Authentication.Azure.dll" target="Dependencies" />
@@ -64,7 +67,6 @@
     <file src="artifacts\Dependencies\Desktop\System.Diagnostics.DiagnosticSource.dll" target="Dependencies\Desktop" />
     <file src="artifacts\Dependencies\Desktop\System.Numerics.Vectors.dll" target="Dependencies\Desktop" />
     <file src="artifacts\Dependencies\Desktop\System.Runtime.CompilerServices.Unsafe.dll" target="Dependencies\Desktop" />
-    <file src="artifacts\Dependencies\Desktop\System.Text.Encodings.Web.dll" target="Dependencies\Desktop" />
     <file src="artifacts\Dependencies\Desktop\System.Net.Http.WinHttpHandler.dll" target="Dependencies\Desktop" />
     <file src="artifacts\Dependencies\Desktop\System.Security.Cryptography.ProtectedData.dll" target="Dependencies\Desktop" />
   </files>
diff --git a/src/Authentication/Authentication/ModuleInitializer.cs b/src/Authentication/Authentication/ModuleInitializer.cs
@@ -86,9 +86,10 @@ public void OnRemove(PSModuleInfo psModuleInfo)
         private static bool IsAssemblyMatching(AssemblyName assemblyName, Assembly requestingAssembly)
         {
             return requestingAssembly != null
-                ? (requestingAssembly.FullName.StartsWith("Microsoft") 
+                ? (requestingAssembly.FullName.StartsWith("Microsoft")
                     || requestingAssembly.FullName.StartsWith("Azure.Identity")
-                    || requestingAssembly.FullName.StartsWith("Azure.Core")) && IsAssemblyPresent(assemblyName)
+                    || requestingAssembly.FullName.StartsWith("Azure.Core")
+                    || requestingAssembly.FullName.StartsWith("System.Text.Json")) && IsAssemblyPresent(assemblyName)
                 : IsAssemblyPresent(assemblyName);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,8 @@ private static async Task<TokenCredential> GetEnvironmentCredentialAsync(IAuthCo`
`78`	`78`
`79`	`79`	`private static bool IsAuthFlowNotSupported()`
`80`	`80`	`{`
`81`		`- return ((!string.IsNullOrEmpty(EnvironmentVariables.Username) && !string.IsNullOrEmpty(EnvironmentVariables.Password))`
`82`		`- && (string.IsNullOrEmpty(EnvironmentVariables.ClientSecret) && string.IsNullOrEmpty(EnvironmentVariables.ClientCertificatePath)));`
	`81`	`+ return !string.IsNullOrEmpty(EnvironmentVariables.Username) && !string.IsNullOrEmpty(EnvironmentVariables.Password)`
	`82`	`+ && string.IsNullOrEmpty(EnvironmentVariables.ClientSecret) && string.IsNullOrEmpty(EnvironmentVariables.ClientCertificatePath);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private static bool ShouldUseWam(IAuthContext authContext)`
`@@ -138,7 +138,7 @@ private static async Task<InteractiveBrowserCredential> GetInteractiveBrowserCre`
`138`	`138`	`{`
`139`	`139`	`return interactiveBrowserCredential.AuthenticateAsync(new TokenRequestContext(authContext.Scopes), cancellationToken);`
`140`	`140`	`});`
`141`		`- }`
	`141`	`+ }`
`142`	`142`	`await WriteAuthRecordAsync(authRecord).ConfigureAwait(false);`
`143`	`143`	`return interactiveBrowserCredential;`
`144`	`144`	`}`
Original file line number	Diff line number	Diff line change
`@@ -86,9 +86,10 @@ public void OnRemove(PSModuleInfo psModuleInfo)`
`86`	`86`	`private static bool IsAssemblyMatching(AssemblyName assemblyName, Assembly requestingAssembly)`
`87`	`87`	`{`
`88`	`88`	`return requestingAssembly != null`
`89`		`- ? (requestingAssembly.FullName.StartsWith("Microsoft")`
	`89`	`+ ? (requestingAssembly.FullName.StartsWith("Microsoft")`
`90`	`90`	`\|\| requestingAssembly.FullName.StartsWith("Azure.Identity")`
`91`		`- \|\| requestingAssembly.FullName.StartsWith("Azure.Core")) && IsAssemblyPresent(assemblyName)`
	`91`	`+ \|\| requestingAssembly.FullName.StartsWith("Azure.Core")`
	`92`	`+ \|\| requestingAssembly.FullName.StartsWith("System.Text.Json")) && IsAssemblyPresent(assemblyName)`
`92`	`93`	`: IsAssemblyPresent(assemblyName);`
`93`	`94`	`}`
`94`	`95`